public inbox for linux-rockchip@lists.infradead.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Vicente Bergas <vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Enric Balletbo i Serra
	<enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>,
	William wu <wulf-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] arm64: dts: rockchip: Fix microSD in Sapphire board
Date: Sat, 22 Sep 2018 22:50:13 +0200	[thread overview]
Message-ID: <2007948.iYuWs6PDBz@phil> (raw)
In-Reply-To: <20180917134714.2197-1-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Am Montag, 17. September 2018, 15:47:14 CEST schrieb Vicente Bergas:
> The microSD card slot in the Sapphire board is not working because of
> several issues:
>  1.- The vmmc power supply is missing in the DTS. It is capable of 3.0V
>  and has a GPIO-based enable control.
>  2.- The vqmmc power supply can provide up to 3.3V, but it is capped in
>  the DTS to just 3.0V because of the vmmc capability. This results in a
>  conflict from the mmc driver requesting an unsupportable voltage range
>  from 3.3V to 3.0V (min > max) as reported in dmesg. So, extend the
>  range up to 3.3V. The hw should be able to stand this 0.3V tolerance.
>  See mmc_regulator_set_vqmmc in drivers/mmc/core/core.c.
>  3.- The card detect signal is non-working. There is a known conflict
>  with jtag, but the workaround in drivers/soc/rockchip/grf.c does not
>  work. Adding the broken-cd attribute to the DTS fixes the issue.
> 
> Signed-off-by: Vicente Bergas <vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

applied for 4.20

Thanks
Heiko

      parent reply	other threads:[~2018-09-22 20:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-17 13:47 [PATCH] arm64: dts: rockchip: Fix microSD in Sapphire board Vicente Bergas
     [not found] ` <20180917134714.2197-1-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-09-22 20:50   ` Heiko Stuebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2007948.iYuWs6PDBz@phil \
    --to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
    --cc=enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=wulf-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox