From: Daniel Vetter <daniel@ffwll.ch>
To: Mark yao <mark.yao@rock-chips.com>
Cc: DRM DRIVERS FOR ROCKCHIP <dri-devel@lists.freedesktop.org>,
list@263.net, Douglas Anderson <dianders@chromium.org>,
stable@vger.kernel.org, open list <linux-kernel@vger.kernel.org>,
ARM/Rockchip SoC support <linux-rockchip@lists.infradead.org>,
moderated@263.net, open@263.net,
ARM/Rockchip SoC support <linux-arm-kernel@lists.infradead.org>,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] drm/rockchip: use drm_gem_mmap helpers
Date: Wed, 8 Jul 2015 09:35:20 +0200 [thread overview]
Message-ID: <20150708073520.GB7568@phenom.ffwll.local> (raw)
In-Reply-To: <559CA1DD.9070905@rock-chips.com>
On Wed, Jul 08, 2015 at 12:06:53PM +0800, Mark yao wrote:
> On 2015年07月07日 20:04, Daniel Vetter wrote:
> >On Tue, Jul 07, 2015 at 05:03:36PM +0800, Daniel Kurtz wrote:
> >>Rather than (incompletely [0]) re-implementing drm_gem_mmap() and
> >>drm_gem_mmap_obj() helpers, call them directly from the rockchip mmap
> >>routines.
> >>
> >>Once the core functions return successfully, the rockchip mmap routines
> >>can still use dma_mmap_attrs() to simply mmap the entire buffer.
> >>
> >>[0] Previously, we were performing the mmap() without first taking a
> >>reference on the underlying gem buffer. This could leak ptes if the gem
> >>object is destroyed while userspace is still holding the mapping.
> >>
> >>Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
> >>Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> >>Cc: stable@vger.kernel.org
> >Applied to topic/drm-fixes to make sure it won't get lost, but I expect
> >rockchip maintainers to pick this one up.
> >-Daniel
> I try to pick this patch up, but found it conflicts with patch [0]. Can you
> fix it?
>
> [0]https://patchwork.kernel.org/patch/6226591/
Imo this should be the other way round since Daniel's patch fixes a fairly
serious issue: Apply this fix first, rebase&queue the polish for -next.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-07-08 7:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 9:03 [PATCH] drm/rockchip: use drm_gem_mmap helpers Daniel Kurtz
2015-07-07 12:04 ` Daniel Vetter
2015-07-08 4:06 ` Mark yao
2015-07-08 7:35 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150708073520.GB7568@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=list@263.net \
--cc=mark.yao@rock-chips.com \
--cc=moderated@263.net \
--cc=open@263.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox