From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH 1/2] drm: Improve drm_of_component_probe() to correctly handle ports and remote ports. Date: Mon, 16 Nov 2015 16:22:41 +0000 Message-ID: <20151116162241.GN8644@n2100.arm.linux.org.uk> References: <1447685093-26129-1-git-send-email-Liviu.Dudau@arm.com> <1447685093-26129-2-git-send-email-Liviu.Dudau@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1447685093-26129-2-git-send-email-Liviu.Dudau@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Liviu Dudau Cc: linux-rockchip , Daniel Vetter , LKML , dri-devel , LAKML List-Id: linux-rockchip.vger.kernel.org T24gTW9uLCBOb3YgMTYsIDIwMTUgYXQgMDI6NDQ6NTJQTSArMDAwMCwgTGl2aXUgRHVkYXUgd3Jv dGU6Cj4gUm9ja2NoaXAgRFJNIGRyaXZlciBjYW5ub3QgdXNlIHRoZSBzYW1lIGNvbXBhcmVfb2Yo KSBmdW5jdGlvbiB0byBtYXRjaAo+IHBvcnRzIGFuZCByZW1vdGUgcG9ydHMgKGFrYSBlbmNvZGVy cykgYXMgdGhlaXIgT0Ygc3ViLXRyZWVzIGxvb2sgZGlmZmVyZW50Lgo+IEFkZCBhIHNlY29uZCBj b21wYXJlIGZ1bmN0aW9uIHRvIGJlIHVzZWQgd2hlbiBlbmNvZGVycyBhcmUgYWRkZWQgdG8gdGhl Cj4gY29tcG9uZW50IGZyYW1ld29yayBhbmQgcGF0Y2ggdGhlIGV4aXN0aW5nIHVzZXJzIG9mIHRo ZSBmdW5jdGlvbgo+IGFjY29yZGluZ2x5Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IExpdml1IER1ZGF1 IDxMaXZpdS5EdWRhdUBhcm0uY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYXJtYWRhL2Fy bWFkYV9kcnYuYyB8ICAzICsrLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX29mLmMgICAgICAgICAg ICB8IDIzICsrKysrKysrKysrKysrKysrKy0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pbXgvaW14 LWRybS1jb3JlLmMgIHwgIDMgKystCj4gIGluY2x1ZGUvZHJtL2RybV9vZi5oICAgICAgICAgICAg ICAgIHwgIDYgKysrKy0tCj4gIDQgZmlsZXMgY2hhbmdlZCwgMjYgaW5zZXJ0aW9ucygrKSwgOSBk ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FybWFkYS9hcm1h ZGFfZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vYXJtYWRhL2FybWFkYV9kcnYuYwo+IGluZGV4IDc3 YWI5M2QuLjNhMmE5MjkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FybWFkYS9hcm1h ZGFfZHJ2LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYXJtYWRhL2FybWFkYV9kcnYuYwo+IEBA IC0yNzQsNyArMjc0LDggQEAgc3RhdGljIGludCBhcm1hZGFfZHJtX3Byb2JlKHN0cnVjdCBwbGF0 Zm9ybV9kZXZpY2UgKnBkZXYpCj4gIAlzdHJ1Y3QgZGV2aWNlICpkZXYgPSAmcGRldi0+ZGV2Owo+ ICAJaW50IHJldDsKPiAgCj4gLQlyZXQgPSBkcm1fb2ZfY29tcG9uZW50X3Byb2JlKGRldiwgY29t cGFyZV9kZXZfbmFtZSwgJmFybWFkYV9tYXN0ZXJfb3BzKTsKPiArCXJldCA9IGRybV9vZl9jb21w b25lbnRfcHJvYmUoZGV2LCBjb21wYXJlX2Rldl9uYW1lLCBjb21wYXJlX2Rldl9uYW1lLAo+ICsJ CQkJICAgICAmYXJtYWRhX21hc3Rlcl9vcHMpOwo+ICAJaWYgKHJldCAhPSAtRUlOVkFMKQo+ICAJ CXJldHVybiByZXQ7Cj4gIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX29mLmMg Yi9kcml2ZXJzL2dwdS9kcm0vZHJtX29mLmMKPiBpbmRleCA0OTNjMDVjLi41OGZhZmQ3IDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fb2YuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9kcm1fb2YuYwo+IEBAIC03Nyw3ICs3Nyw4IEBAIEVYUE9SVF9TWU1CT0woZHJtX29mX2ZpbmRf cG9zc2libGVfY3J0Y3MpOwo+ICAgKiBSZXR1cm5zIHplcm8gaWYgc3VjY2Vzc2Z1bCwgb3Igb25l IG9mIHRoZSBzdGFuZGFyZCBlcnJvciBjb2RlcyBpZiBpdCBmYWlscy4KPiAgICovCj4gIGludCBk cm1fb2ZfY29tcG9uZW50X3Byb2JlKHN0cnVjdCBkZXZpY2UgKmRldiwKPiAtCQkJICAgaW50ICgq Y29tcGFyZV9vZikoc3RydWN0IGRldmljZSAqLCB2b2lkICopLAo+ICsJCQkgICBpbnQgKCpjb21w YXJlX3BvcnQpKHN0cnVjdCBkZXZpY2UgKiwgdm9pZCAqKSwKPiArCQkJICAgaW50ICgqY29tcGFy ZV9lbmNvZGVyKShzdHJ1Y3QgZGV2aWNlICosIHZvaWQgKiksCj4gIAkJCSAgIGNvbnN0IHN0cnVj dCBjb21wb25lbnRfbWFzdGVyX29wcyAqbV9vcHMpCj4gIHsKPiAgCXN0cnVjdCBkZXZpY2Vfbm9k ZSAqZXAsICpwb3J0LCAqcmVtb3RlOwo+IEBAIC0xMDEsOCArMTAyLDE0IEBAIGludCBkcm1fb2Zf Y29tcG9uZW50X3Byb2JlKHN0cnVjdCBkZXZpY2UgKmRldiwKPiAgCQkJY29udGludWU7Cj4gIAkJ fQo+ICAKPiAtCQljb21wb25lbnRfbWF0Y2hfYWRkKGRldiwgJm1hdGNoLCBjb21wYXJlX29mLCBw b3J0KTsKPiAtCQlvZl9ub2RlX3B1dChwb3J0KTsKPiArCQljb21wb25lbnRfbWF0Y2hfYWRkKGRl diwgJm1hdGNoLCBjb21wYXJlX3BvcnQsIHBvcnQpOwo+ICsJCS8qCj4gKwkJICogY29tcG9uZW50 X21hdGNoX2FkZCBrZWVwcyBhIHJlZmVyZW5jZSB0byB0aGUgcG9ydAo+ICsJCSAqIHZhcmlhYmxl IGJ1dCBkb2VzIG5vdCBkbyBwcm9wZXIgcmVmZXJlbmNlIGNvdW50aW5nLAo+ICsJCSAqIHNvIHdl IGNhbm5vdCByZWxlYXNlIHRoZSByZWZlcmVuY2UgaGVyZS4gSWYgdGhhdAo+ICsJCSAqIGdldHMg Zml4ZWQsIHRoZSBmb2xsb3dpbmcgbGluZSBzaG91bGQgYmUgdW5jb21tZW50ZWQKPiArCQkgKi8K PiArCQkvKiBvZl9ub2RlX3B1dChwb3J0KTsgKi8KCkV2ZW4gaWYgaXQgaXMgZml4ZWQsIHRoaXMg bGluZSBzaG91bGQgX25ldmVyXyBiZSB1bmNvbW1lbnRlZC4gIFRoaXMgaXMKdG90YWxseSB0aGUg d3JvbmcgcGxhY2UgdG8gZHJvcCB0aGUgcmVmZXJlbmNlLgoKPiAgCX0KPiAgCj4gIAlpZiAoaSA9 PSAwKSB7Cj4gQEAgLTE0MCw4ICsxNDcsMTQgQEAgaW50IGRybV9vZl9jb21wb25lbnRfcHJvYmUo c3RydWN0IGRldmljZSAqZGV2LAo+ICAJCQkJY29udGludWU7Cj4gIAkJCX0KPiAgCj4gLQkJCWNv bXBvbmVudF9tYXRjaF9hZGQoZGV2LCAmbWF0Y2gsIGNvbXBhcmVfb2YsIHJlbW90ZSk7Cj4gLQkJ CW9mX25vZGVfcHV0KHJlbW90ZSk7Cj4gKwkJCWNvbXBvbmVudF9tYXRjaF9hZGQoZGV2LCAmbWF0 Y2gsIGNvbXBhcmVfZW5jb2RlciwgcmVtb3RlKTsKPiArCQkJLyoKPiArCQkJICogY29tcG9uZW50 X21hdGNoX2FkZCBrZWVwcyBhIHJlZmVyZW5jZSB0byB0aGUgcG9ydAo+ICsJCQkgKiB2YXJpYWJs ZSBidXQgZG9lcyBub3QgZG8gcHJvcGVyIHJlZmVyZW5jZSBjb3VudGluZywKPiArCQkJICogc28g d2UgY2Fubm90IHJlbGVhc2UgdGhlIHJlZmVyZW5jZSBoZXJlLiBJZiB0aGF0Cj4gKwkJCSAqIGdl dHMgZml4ZWQsIHRoZSBmb2xsb3dpbmcgbGluZSBzaG91bGQgYmUgdW5jb21tZW50ZWQKPiArCQkJ ICovCj4gKwkJCS8qIG9mX25vZGVfcHV0KHJlbW90ZSk7ICovCgpEaXR0by4KClRoZSBjb21wb25l bnQgaGVscGVyIHJldGFpbnMgYSByZWZlcmVuY2UgKGJ5IHBvaW50ZXIgdmFsdWUpIHRvIHRoZSAn cG9ydCcKb3IgJ3JlbW90ZScsIHdoaWNoIGlzIHRoZW4gc3Vic2VxdWVudGx5IHBhc3NlZCBpbnRv IHRoZSBzdXBwbGllZAonY29tcGFyZV9lbmNvZGVyJyBvciAnY29tcGFyZV9wb3J0JyBtZXRob2Qu CgpJZiB5b3UgZHJvcCB0aGUgcmVmZXJlbmNlIGFmdGVyIGFkZGluZyB0aGUgbWF0Y2gsIHRoZW4g dGhhdCBwb2ludGVyIGNhbgpnbyBhd2F5IGFuZCBiZSByZS11c2VkIGZvciBzb21ldGhpbmcgZWxz ZSAtIGFuZCB0aGF0IG1lYW5zIGl0J3MgdG90YWxseQp1c2VsZXNzIHRvIHRoZSBjb21wYXJlIGZ1 bmN0aW9ucywgc2luY2UgdGhlIG1lbW9yeSBwb2ludGVkIHRvIGJ5IGl0IG1heQpub3QgY29udGFp biBhbiBkZXZpY2Vfbm9kZSBzdHJ1Y3QgYW55bW9yZS4KClNvLCBpdCBfbmV2ZXJfIG1ha2VzIHNl bnNlIHRvIGRyb3AgdGhlIHJlZmVyZW5jZSBhdCB0aGlzIHBvaW50LgoKV2hlcmUgaXQgZG9lcyBt YWtlIHNlbnNlIGlzIHdoZW4gdGhlIGFycmF5IG9mIG1hdGNoZXMgaXMgZGVzdHJveWVkLiAgRm9y CnRoYXQsIHdlJ2QgbmVlZCB0byBhZGQgYSBjYWxsYmFjayB0byB0aGUgbWFzdGVyIG9wcyBzdHJ1 Y3Qgc28gdGhhdCB0aGUKbWFzdGVyIGRyaXZlciBjYW4gcHJvcGVybHkgcmVsZWFzZSB0aGVzZSBw b2ludGVycy4KCkknZCBrZWVwIG1vc3Qgb2YgdGhlIGJpZyBjb21tZW50cyB0aG91Z2ggKHVwIHRv ICIuLi4gdmFyYWJsZSIpIHRvCmV4cGxhaW4gd2h5IHdlIGRvbid0IGRyb3AgdGhlIHJlZmVyZW5j ZS4KCi0tIApGVFRDIGJyb2FkYmFuZCBmb3IgMC44bWlsZSBsaW5lOiBjdXJyZW50bHkgYXQgOS42 TWJwcyBkb3duIDQwMGticHMgdXAKYWNjb3JkaW5nIHRvIHNwZWVkdGVzdC5uZXQuCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5n IGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==