From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH 2/2] drm/rockchip: Convert the probe function to the generic drm_of_component_probe() Date: Mon, 16 Nov 2015 16:30:16 +0000 Message-ID: <20151116163016.GO8644@n2100.arm.linux.org.uk> References: <1447685093-26129-1-git-send-email-Liviu.Dudau@arm.com> <1447685093-26129-3-git-send-email-Liviu.Dudau@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1447685093-26129-3-git-send-email-Liviu.Dudau@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Liviu Dudau Cc: linux-rockchip , Daniel Vetter , LKML , dri-devel , LAKML List-Id: linux-rockchip.vger.kernel.org SSd2ZSB0d2Vha2VkIHlvdXIgcGF0Y2ggdG8gbWFrZSB0aGUgYWJvdmUgKGJ1Z2d5KSBjaGFuZ2Ug YSBsaXR0bGUgY2xlYXJlci4KCk9uIE1vbiwgTm92IDE2LCAyMDE1IGF0IDAyOjQ0OjUzUE0gKzAw MDAsIExpdml1IER1ZGF1IHdyb3RlOgo+IC0JZm9yIChpID0gMDs7IGkrKykgewo+IC0JCXBvcnQg PSBvZl9wYXJzZV9waGFuZGxlKG5wLCAicG9ydHMiLCBpKTsKPiAtCQlpZiAoIXBvcnQpCj4gLQkJ CWJyZWFrOwo+IC0KPiAtCQlpZiAoIW9mX2RldmljZV9pc19hdmFpbGFibGUocG9ydC0+cGFyZW50 KSkgewo+IC0JCQlvZl9ub2RlX3B1dChwb3J0KTsKPiAtCQkJY29udGludWU7Cj4gLQkJfQo+ICAK PiAtCQljb21wb25lbnRfbWF0Y2hfYWRkKGRldiwgJm1hdGNoLCBjb21wYXJlX29mLCBwb3J0LT5w YXJlbnQpOwo+IC0JCW9mX25vZGVfcHV0KHBvcnQpOwo+IC0JfQoKPiAtc3RhdGljIGludCBjb21w YXJlX29mKHN0cnVjdCBkZXZpY2UgKmRldiwgdm9pZCAqZGF0YSkKPiAtewo+IC0Jc3RydWN0IGRl dmljZV9ub2RlICpucCA9IGRhdGE7Cj4gLQo+IC0JcmV0dXJuIGRldi0+b2Zfbm9kZSA9PSBucDsK PiAtfQoKVGhlIG9yaWdpbmFsIGFib3ZlIHBhc3NlcyBwb3J0LT5wYXJlbnQgdG8gY29tcG9uZW50 X21hdGNoX2FkZCgpLiAgVGhpcwptZWFucyAnbnAnIGluIHRoZSBhYm92ZSBjb21wYXJlX29mKCkg ZnVuY3Rpb24gaXMgJ3BvcnQtPnBhcmVudCcuCgpUaGlzIG1lYW5zIHRoZSBhYm92ZSBjb21wYXJp c29uIGlzIGVmZmVjdGl2ZWx5OgoKCWRldi0+b2Zfbm9kZSA9PSBwb3J0LT5wYXJlbnQKClRoZSBn ZW5lcmljIGNvZGUgaW5zdGVhZCBkb2VzIHRoaXM6CgogICAgICAgICAgICAgICAgY29tcG9uZW50 X21hdGNoX2FkZChkZXYsICZtYXRjaCwgY29tcGFyZV9vZiwgcG9ydCk7CgpTbyB3aGF0IHdlIGdl dCBpbiB0aGUgY29tcGFyaXNvbiBmdW5jdGlvbiBpcyAncG9ydCcgcmF0aGVyIHRoYW4KJ3BvcnQt PnBhcmVudCc6Cgo+ICtzdGF0aWMgaW50IGNvbXBhcmVfcG9ydChzdHJ1Y3QgZGV2aWNlICpkZXYs IHZvaWQgKmRhdGEpCj4gIHsKPiArCXN0cnVjdCBkZXZpY2Vfbm9kZSAqbnAgPSBkYXRhOwo+ICsJ cmV0dXJuIGRldi0+cGFyZW50LT5vZl9ub2RlID09IG5wOwo+ICt9Cgp3aGljaCBtZWFucyB0aGUg Y29tcGFyaXNvbiBpczoKCglkZXYtPnBhcmVudC0+b2Zfbm9kZSA9PSBwb3J0Cgp3aGljaCBpcyBh IGRpZmZlcmVudCBjb21wYXJpc29uIGZyb20gdGhlIGFib3ZlLgoKWW91IGluc3RlYWQgd2FudCB0 aGlzIHRvIGJlOgoKCXJldHVybiBkZXYtPm9mX25vZGUgPT0gbnAtPnBhcmVudDsKCkhlaWtvLCBw bGVhc2UgdGVzdCB0aGUgYWJvdmUgY2hhbmdlIHRvIGNvbXBhcmVfcG9ydCgpIC0gSSB0aGluayB5 b3UnbGwKZmluZCB0aGF0IHdpbGwgZml4IHlvdXIgaXNzdWUuCgpUaGFua3MuCgotLSAKRlRUQyBi cm9hZGJhbmQgZm9yIDAuOG1pbGUgbGluZTogY3VycmVudGx5IGF0IDkuNk1icHMgZG93biA0MDBr YnBzIHVwCmFjY29yZGluZyB0byBzcGVlZHRlc3QubmV0LgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=