public inbox for linux-rockchip@lists.infradead.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Jeffy Chen <jeffy.chen@rock-chips.com>,
	Rob Herring <robh@kernel.org>,
	Paul Kocialkowski <contact@paulk.fr>
Cc: u-boot@lists.denx.de, linux-rockchip@lists.infradead.org,
	Max Krummenacher <max.krummenacher@toradex.com>,
	Joe Hershberger <joe.hershberger@ni.com>
Subject: Re: [PATCH v4 1/6] common/image-fdt.c: Make boot_get_fdt() perform a check for Android images
Date: Wed, 13 Jan 2016 10:21:57 -0500	[thread overview]
Message-ID: <20160113152157.GY3359@bill-the-cat> (raw)
In-Reply-To: <1452675200-15941-2-git-send-email-jeffy.chen@rock-chips.com>


[-- Attachment #1.1: Type: text/plain, Size: 1054 bytes --]

On Wed, Jan 13, 2016 at 04:53:15PM +0800, Jeffy Chen wrote:

> Android images don't have a fdt.
> 
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> Acked-by: Simon Glass <sjg@chromium.org>
> ---
> 
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
> 
>  common/image-fdt.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/common/image-fdt.c b/common/image-fdt.c
> index 5e4e5bd..41aaa0d 100644
> --- a/common/image-fdt.c
> +++ b/common/image-fdt.c
> @@ -379,6 +379,10 @@ int boot_get_fdt(int flag, int argc, char * const argv[], uint8_t arch,
>  				       (long)fdt_addr);
>  			}
>  			break;
> +#ifdef CONFIG_ANDROID_BOOT_IMAGE
> +		case IMAGE_FORMAT_ANDROID:
> +			goto no_fdt;
> +#endif
>  		default:
>  			puts("ERROR: Did not find a cmdline Flattened Device Tree\n");
>  			goto no_fdt;

Hang on, this doesn't seem right.  Rob or Paul can you comment more
here?  I know we've gone through some issues in the past with respect to
booting Android and FDT.  Thanks!

-- 
Tom

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 134 bytes --]

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

  reply	other threads:[~2016-01-13 15:21 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-13  8:53 [PATCH v4 0/6] rockchip: kylin: Boot with android boot image Jeffy Chen
     [not found] ` <1452675200-15941-1-git-send-email-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-01-13  8:53   ` [PATCH v4 1/6] common/image-fdt.c: Make boot_get_fdt() perform a check for Android images Jeffy Chen
2016-01-13 15:21     ` Tom Rini [this message]
2016-01-14  1:47       ` [U-Boot] " Jeffy Chen
2016-01-13  8:53   ` [PATCH v4 2/6] ARM: bootm: Try to use relocated ramdisk Jeffy Chen
2016-01-13 15:27     ` Tom Rini
2016-01-13  8:53   ` [PATCH v4 3/6] rockchip: rk3036: Bind GPIO banks Jeffy Chen
2016-01-13 15:28     ` Tom Rini
2016-01-13  8:53   ` [PATCH v4 4/6] rockchip: kylin: Add default gpt partition table Jeffy Chen
2016-01-13 15:28     ` Tom Rini
2016-01-13  8:53   ` [PATCH v4 5/6] rockchip: kylin: Enable boot with android boot image Jeffy Chen
2016-01-13 15:28     ` Tom Rini
2016-01-14  2:31       ` [U-Boot] " Jeffy Chen
2016-01-14 16:22         ` Tom Rini
2016-01-15  0:53           ` Jeffy Chen
2016-01-15  0:59             ` Tom Rini
2016-01-15  2:20               ` Jeffy Chen
2016-01-15 14:42                 ` Tom Rini
2016-01-15 15:42                   ` Daniel Schwierzeck
2016-01-16  1:18                     ` Simon Glass
     [not found]                       ` <CAPnjgZ1SUJDVPFVXgJjEYgom7tEdaORUAjQ8QfQ8jCpw=NtcJQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-22  3:13                         ` [U-Boot] " Simon Glass
2016-01-25 16:57                     ` Tom Rini
     [not found]                 ` <5698577B.8040209-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-01-25 19:07                   ` [U-Boot] " Tom Rini
2016-02-02  7:13                     ` Jeffy Chen
     [not found]                       ` <56B056FD.70006-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-02-19 20:55                         ` [U-Boot] " Simon Glass
2016-01-13  8:53   ` [PATCH v4 6/6] rockchip: kylin: Check fastboot request Jeffy Chen
     [not found]     ` <1452675200-15941-7-git-send-email-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-01-13 15:28       ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160113152157.GY3359@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=contact@paulk.fr \
    --cc=jeffy.chen@rock-chips.com \
    --cc=joe.hershberger@ni.com \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=max.krummenacher@toradex.com \
    --cc=robh@kernel.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox