linux-rockchip.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Michael Turquette <mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
To: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [GIT PULL] first bunch of rockchip clock changes for 4.6
Date: Fri, 12 Feb 2016 07:13:29 -0800	[thread overview]
Message-ID: <20160212151329.1685.89663@quark.deferred.io> (raw)
In-Reply-To: <1494732.M6VqoIU5NQ@phil>

Quoting Heiko Stuebner (2016-02-12 03:39:43)
> Hi Mike,
> 
> Am Donnerstag, 11. Februar 2016, 18:19:36 schrieb Michael Turquette:
> > Quoting Heiko Stuebner (2016-02-11 05:00:02)
> > 
> > > Yakir Yang (1):
> > >       clk: rockchip: rk3036: enable the CLK_IGNORE_UNUSED flag for
> > >       hclk_vio_bus
> > 
> > Thanks for sending the very readable PR. One question below,
> > 
> > We'll likely have critical clock and handoff clock support merged in the
> > next few days. I'm starting to audit any new CLK_IGNORE_UNUSED flag
> > usage to see if it should use either of those two flags. Is the above
> > patch a candidate?
> 
> the above clock is part of the interconnect. We don't model that yet, but I 
> guess that would make it more a candidate for the handoff-type instead.
> 
> I'd guess for the Rockchip side, everything that is CLK_IGNORE_UNUSED should 
> be the handoff type (leaf-clocks used by some component we don't control 
> yet). 
> 
> The clocks we already register as critical most likely are the ones that 
> should be critical, as they are central clocks where it causes havok when 
> they get disabled :-) .

OK. It sounds like you might go back and clean up these clocks to use
the new infrastructure once it gets merged, so I'll go ahead and pull
this tag now.

Thanks,
Mike

> 
> 
> Heiko

  reply	other threads:[~2016-02-12 15:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-11 13:00 [GIT PULL] first bunch of rockchip clock changes for 4.6 Heiko Stuebner
2016-02-12  2:19 ` Michael Turquette
2016-02-12 11:39   ` Heiko Stuebner
2016-02-12 15:13     ` Michael Turquette [this message]
2016-02-12 16:26       ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160212151329.1685.89663@quark.deferred.io \
    --to=mturquette-rdvid1duhrbwk0htik3j/w@public.gmane.org \
    --cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
    --cc=linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).