From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 03/17] drm/exynos: removed optional dummy encoder mode_fixup function. Date: Tue, 16 Feb 2016 15:31:28 +0100 Message-ID: <20160216143128.GE32705@phenom.ffwll.local> References: <3768b670931572de51fca1102efa18d20dd770ee.1455540137.git.palminha@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Patrik Jakobsson Cc: k.kozlowski@samsung.com, linux-samsung-soc@vger.kernel.org, jingoohan1@gmail.com, Carlos Palminha , dri-devel , virtualization@lists.linux-foundation.org, linux-rockchip@lists.infradead.org, kgene@kernel.org, benjamin.gaignard@linaro.org, vincent.abriou@st.com, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org On Mon, Feb 15, 2016 at 02:49:09PM +0100, Patrik Jakobsson wrote: > Hi Carlos > > Any particular reason why this patch isn't squashed with patch 8/17? I've squashed them while applying. -Daniel > > Thanks > Patrik > > > On Mon, Feb 15, 2016 at 1:58 PM, Carlos Palminha > wrote: > > mode_fixup function for encoder drivers became optional with patch > > http://patchwork.freedesktop.org/patch/msgid/1455106522-32307-1-git-send-email-palminha@synopsys.com > > > > This patch set nukes all the dummy mode_fixup implementations. > > > > (made on top of Daniel topic/drm-misc branch) > > > > Signed-off-by: Carlos Palminha > > --- > > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 8 -------- > > 1 file changed, 8 deletions(-) > > > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > > index e977a81..736115c 100644 > > --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c > > +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > > @@ -1597,13 +1597,6 @@ static int exynos_dsi_create_connector(struct drm_encoder *encoder) > > return 0; > > } > > > > -static bool exynos_dsi_mode_fixup(struct drm_encoder *encoder, > > - const struct drm_display_mode *mode, > > - struct drm_display_mode *adjusted_mode) > > -{ > > - return true; > > -} > > - > > static void exynos_dsi_mode_set(struct drm_encoder *encoder, > > struct drm_display_mode *mode, > > struct drm_display_mode *adjusted_mode) > > @@ -1623,7 +1616,6 @@ static void exynos_dsi_mode_set(struct drm_encoder *encoder, > > } > > > > static const struct drm_encoder_helper_funcs exynos_dsi_encoder_helper_funcs = { > > - .mode_fixup = exynos_dsi_mode_fixup, > > .mode_set = exynos_dsi_mode_set, > > .enable = exynos_dsi_enable, > > .disable = exynos_dsi_disable, > > -- > > 2.5.0 > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch