From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: John Keeping <john@keeping.me.uk>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Douglas Anderson <dianders@chromium.org>,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] drm/rockchip: dw_hdmi: Call drm_encoder_cleanup() in error path
Date: Sat, 5 Mar 2016 12:39:42 +0000 [thread overview]
Message-ID: <20160305123942.GE19428@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20160305121005.GA11966@serenity.lan>
On Sat, Mar 05, 2016 at 12:11:16PM +0000, John Keeping wrote:
> On Fri, Mar 04, 2016 at 03:22:01PM -0800, Douglas Anderson wrote:
> > The drm_encoder_cleanup() was missing both from the error path of
> > dw_hdmi_rockchip_bind(). This caused a crash when slub_debug was
> > enabled and we ended up deferring probe of HDMI at boot.
> >
> > This call isn't needed from unbind() because if dw_hdmi_bind() returns
> > no error then it takes over the job of freeing the encoder (in
> > dw_hdmi_unbind).
> >
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> > ---
>
> Does dw_hdmi-imx need a similar change? I wonder if it would be cleaner
> to push this into dw_hdmi_bind() if it affects all of the platforms..
I don't think moving it there would make sense - keep the initialisation
and cleanup together in the same file so that it's contained together.
--
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-03-05 12:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 23:22 [PATCH 1/2] drm/rockchip: dw_hdmi: Call drm_encoder_cleanup() in error path Douglas Anderson
2016-03-04 23:22 ` [PATCH 2/2] drm/rockchip: vop: Fix vop crtc cleanup Douglas Anderson
2016-03-05 12:11 ` [PATCH 1/2] drm/rockchip: dw_hdmi: Call drm_encoder_cleanup() in error path John Keeping
2016-03-05 12:39 ` Russell King - ARM Linux [this message]
2016-03-07 8:37 ` Mark yao
2016-03-07 17:36 ` Doug Anderson
2016-03-07 17:57 ` Heiko Stübner
2016-03-07 18:49 ` Doug Anderson
2016-03-07 18:56 ` Heiko Stübner
2016-03-07 19:26 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160305123942.GE19428@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=john@keeping.me.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox