From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v3 00/12] pwm: add support for atomic update Date: Fri, 11 Mar 2016 10:51:46 +0100 Message-ID: <20160311105146.510468ef@bbrezillon> References: <20160203145337.GD9650@ulmo> <20160222175929.GA23899@ulmo> <20160223143859.GA27656@ulmo> <20160223181448.GA14754@ulmo.nvidia.com> <20160310175438.GA5648@ulmo.nvidia.com> Reply-To: boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20160310175438.GA5648-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Thierry Reding Cc: Doug Anderson , Heiko =?UTF-8?B?U3TDvGJuZXI=?= , linux-pwm , Mark Brown , Liam Girdwood , Jingoo Han , Lee Jones , linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Bryan Wu , Richard Purdie , Jacek Anaszewski , linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Maxime Ripard , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, "open list:ARM/Rockchip SoC..." , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Daniel Mack , Haojian Zhuang , Robert Jarzmik , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" linu List-Id: linux-rockchip.vger.kernel.org Hi Thierry, On Thu, 10 Mar 2016 18:54:38 +0100 Thierry Reding wrote: > On Mon, Mar 07, 2016 at 08:34:19AM -0800, Doug Anderson wrote: > > Thierry, > > > > On Thu, Feb 25, 2016 at 3:14 PM, Doug Anderson wrote: > > > So just to summarize: > > > > > > * Add pwm_get_state(), pwm_apply_state(), pwm_get_args(). > > > pwm_get_state() initially returns 0 for duty cycle if driver doesn't > > > support readout. > > > > > > * Re-implement pwm_get_period() (and maybe other similar functions) > > > atop pwm_get_state() as you describe earlier in the thread. > > > > > > * Document pwm_get_period() (and maybe other similar functions) as deprecated. > > > > > > * Fix drivers for all current 2 users of PWM regulator to support > > > hardware readout. > > > > > > * Update PWM regulator as you described earlier in the thread (Feb 23). > > > > > > * If PWM regulator is ever used on a new board whose PWM doesn't > > > support hardware readout, the voltage will change at probe time. > > > > > > > > > Did I get all that right? Thanks! > > > > Can you provide a "yes, you got that right" or a "no, you didn't > > understand"? That will unblock Boris, I think. > > Sounds about right. Hopefully this will eliminate any objections that > others had about the series. Okay, I'll rework the series accordingly and send a new version soon. Thanks, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com