From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Wadim Egorov <w.egorov-guT5V/WYfQezQB+pC5nmwQ@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org,
alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org
Subject: Re: [PATCH v2 3/7] regulator: rk808: Migrate to regulator core's simplified DT parsing code
Date: Thu, 21 Apr 2016 17:01:20 +0100 [thread overview]
Message-ID: <20160421160120.GT3217@sirena.org.uk> (raw)
In-Reply-To: <1461244361-45686-4-git-send-email-w.egorov-guT5V/WYfQezQB+pC5nmwQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 571 bytes --]
On Thu, Apr 21, 2016 at 03:12:37PM +0200, Wadim Egorov wrote:
> +static int rk808_set_suspend_voltage(struct regulator_dev *rdev, int uv)
> +{
> + unsigned int reg;
> + int sel = regulator_map_voltage_linear(rdev, uv, uv);
> +
> + if (sel < 0)
> + return -EINVAL;
> +
> + reg = rdev->desc->vsel_reg + RK808_SLP_REG_OFFSET;
> +
> + return regmap_update_bits(rdev->regmap, reg,
> + rdev->desc->vsel_mask,
> + sel);
> +}
This is fine but is adding a new feature and not part of the refactoring
that the changelog talked about so should be in a separate commit.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-04-21 16:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 13:12 [PATCH v2 0/5] Add support for rk818 Wadim Egorov
2016-04-21 13:12 ` [PATCH v2 1/7] drivers: mfd: rk808: rename rk808 struct to rk8xx Wadim Egorov
2016-04-21 14:20 ` Alexandre Belloni
2016-04-21 13:12 ` [PATCH v2 2/7] mfd: RK808: Add RK818 support Wadim Egorov
[not found] ` <1461244361-45686-1-git-send-email-w.egorov-guT5V/WYfQezQB+pC5nmwQ@public.gmane.org>
2016-04-21 13:12 ` [PATCH v2 3/7] regulator: rk808: Migrate to regulator core's simplified DT parsing code Wadim Egorov
[not found] ` <1461244361-45686-4-git-send-email-w.egorov-guT5V/WYfQezQB+pC5nmwQ@public.gmane.org>
2016-04-21 16:01 ` Mark Brown [this message]
2016-04-22 9:03 ` Wadim Egorov
[not found] ` <5719E8CD.1070304-guT5V/WYfQezQB+pC5nmwQ@public.gmane.org>
2016-04-22 9:41 ` Mark Brown
2016-04-21 13:12 ` [PATCH v2 4/7] regulator: rk808: Add regulator driver for RK818 Wadim Egorov
2016-04-21 16:02 ` Mark Brown
2016-04-21 13:12 ` [PATCH v2 7/7] rtc: Kconfig: Name RK818 in Kconfig for RTC_DRV_RK808 Wadim Egorov
[not found] ` <1461244361-45686-8-git-send-email-w.egorov-guT5V/WYfQezQB+pC5nmwQ@public.gmane.org>
2016-04-21 14:35 ` Alexandre Belloni
2016-04-21 13:12 ` [PATCH v2 5/7] mfd: dt-bindings: Add RK818 device tree bindings document Wadim Egorov
2016-04-22 20:25 ` Rob Herring
2016-04-21 13:12 ` [PATCH v2 6/7] clk: Kconfig: Name RK818 in Kconfig for COMMON_CLK_RK808 Wadim Egorov
[not found] ` <1461244361-45686-7-git-send-email-w.egorov-guT5V/WYfQezQB+pC5nmwQ@public.gmane.org>
2016-04-22 21:37 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160421160120.GT3217@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org \
--cc=alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=w.egorov-guT5V/WYfQezQB+pC5nmwQ@public.gmane.org \
--cc=zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox