Re: [PATCH 1/4] thermal: Add support for hardware-tracked trip points

Caesar Wang
2016-05-03T09:25:47Z

在 2016年04月28日 05:48, Eduardo Valentin 写道:
> This patch is based on an earlier version from Mikko Perttunen
> <mikko.perttunen@kapsi.fi>
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Eduardo Valentin <edubezval@gmail.com>
> Cc: linux-pm@vger.kernel.org
> ---
>
> drivers/thermal/thermal_core.c | 48 ++++++++++++++++++++++++++++++++++++++++++
> include/linux/thermal.h | 3 +++
>>
>
> static void update_temperature(struct thermal_zone_device *tz)
> {
> int temp, ret;
> @@ -569,6 +610,8 @@ void thermal_zone_device_update(struct thermal_zone_device *tz)
>
> update_temperature(tz);
>
> + thermal_zone_set_trips(tz);
> +
> for (count = 0; count < tz->trips; count++)
> handle_thermal_trip(tz, count);
> }
> @@ -754,6 +797,9 @@ trip_point_hyst_store(struct device *dev, struct device_attribute *attr,
> */
> ret = tz->ops->set_trip_hyst(tz, trip, temperature);
>
> + if (!ret)
> + thermal_zone_set_trips(tz);
> +
> You would probably want to do the same on trip_point_temp_store().
>

Sorry, that has been set in thermal_zone_device_update().

static ssize_t trip_point_temp_store()
{
..
thermal_zone_device_update(tz);
..
}

> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip

--
Thanks,
Caesar