From: Daniel Vetter <daniel@ffwll.ch>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
Chris Zhong <zyw@rock-chips.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm: rockchip: select DRM_GEM_CMA_HELPER
Date: Thu, 16 Jun 2016 14:37:33 +0200 [thread overview]
Message-ID: <20160616123733.GB23520@phenom.ffwll.local> (raw)
In-Reply-To: <20160616122800.1174015-1-arnd@arndb.de>
On Thu, Jun 16, 2016 at 02:27:57PM +0200, Arnd Bergmann wrote:
> The rockchip drm driver started using drm_gem_cma_vm_ops, but that might
> not be part of the kernel, causing the link to fail:
>
> drivers/gpu/built-in.o:(.data+0xb234): undefined reference to `drm_gem_cma_vm_ops'
>
> This adds a Kconfig 'select' statement to enable it like the other
> user do.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 80f67cd80add ("drm/rockchip: Use cma gem vm ops")
Applied to drm-misc, thanks.
-Daniel
> ---
> drivers/gpu/drm/rockchip/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
> index d30bdc38a760..e48611e83c03 100644
> --- a/drivers/gpu/drm/rockchip/Kconfig
> +++ b/drivers/gpu/drm/rockchip/Kconfig
> @@ -2,6 +2,7 @@ config DRM_ROCKCHIP
> tristate "DRM Support for Rockchip"
> depends on DRM && ROCKCHIP_IOMMU
> depends on RESET_CONTROLLER
> + select DRM_GEM_CMA_HELPER
> select DRM_KMS_HELPER
> select DRM_KMS_FB_HELPER
> select DRM_PANEL
> --
> 2.9.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-06-16 12:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 12:27 [PATCH] drm: rockchip: select DRM_GEM_CMA_HELPER Arnd Bergmann
2016-06-16 12:37 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160616123733.GB23520@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=arnd@arndb.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox