From: Romain Perier <romain.perier@collabora.com>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, Heiko Stuebner <heiko@sntech.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
linux-rockchip@lists.infradead.org,
Sjoerd Simons <sjoerd.simons@collabora.co.uk>,
Rob Herring <robh+dt@kernel.org>,
Kumar Gala <galak@codeaurora.org>,
Romain Perier <romain.perier@collabora.com>
Subject: [PATCH v8 2/4] ASoC: Allow to select ES8328_I2C and ES8328_SPI directly
Date: Fri, 3 Feb 2017 15:37:58 +0100 [thread overview]
Message-ID: <20170203143800.23859-3-romain.perier@collabora.com> (raw)
In-Reply-To: <20170203143800.23859-1-romain.perier@collabora.com>
Currently, we have to select these symbols explictly via Kconfig, from
another entry. If we plan to use generic audio drivers like
simple-audio-card, the user need to be able to enable these symbols
directly via the menuconfig.
This commit also fixes unmet dependencies to SND_SOC_IMX_ES8328 caused
by these changes.
Signed-off-by: Romain Perier <romain.perier@collabora.com>
---
Changes in v8:
- Fixed unmet direct dependencies reported by kbuilt test robot:
"warning: (SND_SOC_IMX_ES8328 && SND_SOC_ALL_CODECS) selects
SND_SOC_ES8328_I2C which has unmet direct dependencies (SOUND && !M68K
&& !UML && SND && SND_SOC && SND_SOC_ES8328)
warning: (SND_SOC_IMX_ES8328 && SND_SOC_ALL_CODECS) selects
SND_SOC_ES8328_SPI which has unmet direct dependencies (SOUND && !M68K
&& !UML && SND && SND_SOC && SND_SOC_ES8328)
"
Changes in v7:
- Added this commit
sound/soc/codecs/Kconfig | 8 ++++----
sound/soc/fsl/Kconfig | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 9e1718a..cfa4233 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -528,12 +528,12 @@ config SND_SOC_ES8328
tristate "Everest Semi ES8328 CODEC"
config SND_SOC_ES8328_I2C
- tristate
- select SND_SOC_ES8328
+ depends on SND_SOC_ES8328
+ tristate "I2C support for Everest Semi ES8328 CODEC"
config SND_SOC_ES8328_SPI
- tristate
- select SND_SOC_ES8328
+ depends on SND_SOC_ES8328
+ tristate "SPI support for Everest Semi ES8328 CODEC"
config SND_SOC_GTM601
tristate 'GTM601 UMTS modem audio codec'
diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
index 37f9b62..0b914a1 100644
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -244,7 +244,7 @@ config SND_SOC_IMX_WM8962
config SND_SOC_IMX_ES8328
tristate "SoC Audio support for i.MX boards with the ES8328 codec"
- depends on OF && (I2C || SPI)
+ depends on OF && (I2C || SPI) && SND_SOC_ES8328
select SND_SOC_ES8328_I2C if I2C
select SND_SOC_ES8328_SPI if SPI_MASTER
select SND_SOC_IMX_PCM_DMA
--
2.9.3
next prev parent reply other threads:[~2017-02-03 14:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 14:37 [PATCH v8 0/4] Add support for es8388 and hdmi audio on the rock2 Romain Perier
2017-02-03 14:37 ` [PATCH v8 1/4] ASoC: es8328: Add support for slave mode Romain Perier
2017-02-03 14:37 ` Romain Perier [this message]
[not found] ` <20170203143800.23859-3-romain.perier-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2017-02-04 12:18 ` Applied "ASoC: Allow to select ES8328_I2C and ES8328_SPI directly" to the asoc tree Mark Brown
2017-02-03 14:37 ` [PATCH v8 3/4] ASoC: rockchip: Add machine driver for RK3288 boards that use analog/HDMI Romain Perier
2017-02-03 14:38 ` [PATCH v8 4/4] arm: dts: Add support for ES8388 to the Radxa Rock 2 Romain Perier
[not found] ` <20170203143800.23859-5-romain.perier-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2017-02-04 14:15 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170203143800.23859-3-romain.perier@collabora.com \
--to=romain.perier@collabora.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=sjoerd.simons@collabora.co.uk \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox