From mboxrd@z Thu Jan  1 00:00:00 1970
From: John Keeping <john@metanate.com>
Subject: Re: [PATCH 2/3] drm/rockchip/dsi: enable the grf clk before writing
 grf registers
Date: Wed, 15 Mar 2017 16:55:11 +0000
Message-ID: <20170315165511.336783bb.john@metanate.com>
References: <1489567352-3333-1-git-send-email-zyw@rock-chips.com>
 <1489567352-3333-2-git-send-email-zyw@rock-chips.com>
 <20170315164726.GA54312@google.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-Reply-To: <20170315164726.GA54312@google.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Brian Norris <briannorris@chromium.org>, Chris Zhong <zyw@rock-chips.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org
List-Id: linux-rockchip.vger.kernel.org

T24gV2VkLCAxNSBNYXIgMjAxNyAwOTo0NzoyOSAtMDcwMCwgQnJpYW4gTm9ycmlzIHdyb3RlOgoK
PiBPbiBXZWQsIE1hciAxNSwgMjAxNyBhdCAwNDo0MjozMVBNICswODAwLCBDaHJpcyBaaG9uZyB3
cm90ZToKPiA+IEZvciBSSzMzOTksIHRoZSBncmYgY2xrIHNob3VsZCBiZSBlbmFibGVkIGJlZm9y
ZSB3cml0aW5nIGdyZiByZWdpc3RlcnMsCj4gPiBvdGhlcndpc2UgdGhlIHJlZ2lzdGVyIHZhbHVl
IGNhbiBub3QgYmUgY2hhbmdlZC4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgWmhvbmcg
PHp5d0Byb2NrLWNoaXBzLmNvbT4KPiA+IC0tLQo+ID4gCj4gPiAgZHJpdmVycy9ncHUvZHJtL3Jv
Y2tjaGlwL2R3LW1pcGktZHNpLmMgfCAyNCArKysrKysrKysrKysrKysrKysrKysrKysKPiA+ICAx
IGZpbGUgY2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJp
dmVycy9ncHUvZHJtL3JvY2tjaGlwL2R3LW1pcGktZHNpLmMgYi9kcml2ZXJzL2dwdS9kcm0vcm9j
a2NoaXAvZHctbWlwaS1kc2kuYwo+ID4gaW5kZXggZjg0ZjlhZS4uZDhmMjRmMiAxMDA2NDQKPiA+
IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9kdy1taXBpLWRzaS5jCj4gPiArKysgYi9k
cml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvZHctbWlwaS1kc2kuYwo+ID4gQEAgLTI5MSw2ICsyOTEs
NyBAQCBzdHJ1Y3QgZHdfbWlwaV9kc2kgewo+ID4gIAlzdHJ1Y3QgcmVnbWFwICpncmZfcmVnbWFw
Owo+ID4gIAl2b2lkIF9faW9tZW0gKmJhc2U7Cj4gPiAgCj4gPiArCXN0cnVjdCBjbGsgKmdyZl9j
bGs7Cj4gPiAgCXN0cnVjdCBjbGsgKnBsbHJlZl9jbGs7Cj4gPiAgCXN0cnVjdCBjbGsgKnBjbGs7
Cj4gPiAgCXN0cnVjdCBjbGsgKnBoeV9jZmdfY2xrOwo+ID4gQEAgLTk3OSw2ICs5ODAsMTYgQEAg
c3RhdGljIHZvaWQgZHdfbWlwaV9kc2lfZW5jb2Rlcl9lbmFibGUoc3RydWN0IGRybV9lbmNvZGVy
ICplbmNvZGVyKQo+ID4gIAlkd19taXBpX2RzaV9kcGh5X2ludGVyZmFjZV9jb25maWcoZHNpKTsK
PiA+ICAJZHdfbWlwaV9kc2lfY2xlYXJfZXJyKGRzaSk7Cj4gPiAgCj4gPiArCS8qCj4gPiArCSAq
IEZvciB0aGUgUkszMzk5LCB0aGUgY2xrIG9mIGdyZiBtdXN0IGJlIGVuYWJsZWQgYmVmb3JlIHdy
aXRpbmcgZ3JmCj4gPiArCSAqIHJlZ2lzdGVyLgo+ID4gKwkgKi8KPiA+ICsJcmV0ID0gY2xrX3By
ZXBhcmVfZW5hYmxlKGRzaS0+Z3JmX2Nsayk7Cj4gPiArCWlmIChyZXQpIHsKPiA+ICsJCWRldl9l
cnIoZHNpLT5kZXYsICJGYWlsZWQgdG8gZW5hYmxlIGdyZl9jbGtcbiIpOwo+ID4gKwkJcmV0dXJu
Owo+ID4gKwl9Cj4gPiArCj4gPiAgCWlmIChwZGF0YS0+Z3JmX2RzaTBfbW9kZV9yZWcpCj4gPiAg
CQlyZWdtYXBfd3JpdGUoZHNpLT5ncmZfcmVnbWFwLCBwZGF0YS0+Z3JmX2RzaTBfbW9kZV9yZWcs
Cj4gPiAgCQkJICAgICBwZGF0YS0+Z3JmX2RzaTBfbW9kZSk7Cj4gPiBAQCAtMTAwMyw2ICsxMDE0
LDggQEAgc3RhdGljIHZvaWQgZHdfbWlwaV9kc2lfZW5jb2Rlcl9lbmFibGUoc3RydWN0IGRybV9l
bmNvZGVyICplbmNvZGVyKQo+ID4gIAlyZWdtYXBfd3JpdGUoZHNpLT5ncmZfcmVnbWFwLCBwZGF0
YS0+Z3JmX3N3aXRjaF9yZWcsIHZhbCk7Cj4gPiAgCWRldl9kYmcoZHNpLT5kZXYsICJ2b3AgJXMg
b3V0cHV0IHRvIGRzaTBcbiIsIChtdXgpID8gIkxJVCIgOiAiQklHIik7Cj4gPiAgCWRzaS0+ZHBt
c19tb2RlID0gRFJNX01PREVfRFBNU19PTjsKPiA+ICsKPiA+ICsJY2xrX2Rpc2FibGVfdW5wcmVw
YXJlKGRzaS0+Z3JmX2Nsayk7Cj4gPiAgfQo+ID4gIAo+ID4gIHN0YXRpYyBpbnQKPiA+IEBAIC0x
MjM4LDYgKzEyNTEsMTcgQEAgc3RhdGljIGludCBkd19taXBpX2RzaV9iaW5kKHN0cnVjdCBkZXZp
Y2UgKmRldiwgc3RydWN0IGRldmljZSAqbWFzdGVyLAo+ID4gIAkJZGV2X2RiZyhkZXYsICJoYXZl
IG5vdCBwaHlfY2ZnX2Nsa1xuIik7Cj4gPiAgCX0KPiA+ICAKPiA+ICsJZHNpLT5ncmZfY2xrID0g
ZGV2bV9jbGtfZ2V0KGRldiwgImdyZiIpOwo+ID4gKwlpZiAoSVNfRVJSKGRzaS0+Z3JmX2Nsaykp
IHsKPiA+ICsJCXJldCA9IFBUUl9FUlIoZHNpLT5ncmZfY2xrKTsKPiA+ICsJCWlmIChyZXQgIT0g
LUVOT0VOVCkgewo+ID4gKwkJCWRldl9lcnIoZGV2LCAiVW5hYmxlIHRvIGdldCBncmZfY2xrOiAl
ZFxuIiwgcmV0KTsgIAo+IAo+IElmIHlvdSdyZSBnb2luZyB0byBwcmludCBhbiBlcnJvciwgeW91
IHNob3VsZCBwcm9iYWJseSBjaGVjayBmb3IKPiAtRVBST0JFX0RFRkVSLiBUaGlzIGRyaXZlciBp
c24ndCBxdWl0ZSBjb25zaXN0ZW50IGFib3V0IHRoaXMuCj4gCj4gPiArCQkJcmV0dXJuIHJldDsK
PiA+ICsJCX0KPiA+ICsJCWRzaS0+Z3JmX2NsayA9IE5VTEw7Cj4gPiArCQlkZXZfZGJnKGRldiwg
ImhhdmUgbm90IGdyZl9jbGtcbiIpOyAgCj4gCj4gVGhlIHdvcmRpbmcgaXMgYSBsaXR0bGUgYXdr
d2FyZDsgbWF5YmUgIm5vIGdyZl9jbGsgcHJvdmlkZWRcbiI/Cj4gCj4gQWxzbywgdG8gYmUgY2xl
YXIsIHRoaXMgY2xvY2sgaXMgcmVxdWlyZWQgZm9yIFJLMzM5OSwgYnV0IG5vdCBmb3Igb3RoZXJz
Cj4gKGUuZy4sIFJLMzI4OCkgcmlnaHQ/IEkgZ3Vlc3MgdGhpcyBtYWtlcyBzZW5zZSB0aGVuLCB0
byBqdXN0IHRyZWF0IGl0IGFzCj4gb3B0aW9uYWwgZm9yIGFsbCBjYXNlcywgZXZlbiBpZiB5b3Ug
ZG9jdW1lbnQgaXQgYXMgInJlcXVpcmVkIiBmb3IKPiBSSzMzOTkuCgpJZiBSSzMzOTkgaXMgYnJv
a2VuIHdpdGhvdXQgZ3JmX2NsaywgSSB3b25kZXIgaWYgdGhlcmUgc2hvdWxkIGJlIGEgZmxhZwpp
biBkd19taXBpX2RzaV9wbGF0X2RhdGEgc28gdGhhdCB0aGUgZHJpdmVyIGNhbiBlbmZvcmNlICJy
ZXF1aXJlZCBmb3IKUkszMzk5Ii4KCgpKb2huCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz
LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp
c3RpbmZvL2RyaS1kZXZlbAo=