From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sean Paul <seanpaul@chromium.org>
Subject: Re: [PATCH v3 3/4] drm/rockchip/dsi: enable the grf clk before
 writing grf registers
Date: Tue, 21 Mar 2017 16:30:39 -0400
Message-ID: <20170321203039.GK19389@art_vandelay>
References: <1489722865-22122-1-git-send-email-zyw@rock-chips.com>
 <1489722865-22122-4-git-send-email-zyw@rock-chips.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <1489722865-22122-4-git-send-email-zyw@rock-chips.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Chris Zhong <zyw@rock-chips.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
List-Id: linux-rockchip.vger.kernel.org

T24gRnJpLCBNYXIgMTcsIDIwMTcgYXQgMTE6NTQ6MjNBTSArMDgwMCwgQ2hyaXMgWmhvbmcgd3Jv
dGU6Cj4gRm9yIFJLMzM5OSwgdGhlIGdyZiBjbGsgc2hvdWxkIGJlIGVuYWJsZWQgYmVmb3JlIHdy
aXRpbmcgZ3JmIHJlZ2lzdGVycywKPiBvdGhlcndpc2UgdGhlIHJlZ2lzdGVyIHZhbHVlIGNhbiBu
b3QgYmUgY2hhbmdlZC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBaaG9uZyA8enl3QHJvY2st
Y2hpcHMuY29tPgoKTWlub3Igbml0IGJlbG93LCB3aXRoIHRoYXQ6CgpSZXZpZXdlZC1ieTogU2Vh
biBQYXVsIDxzZWFucGF1bEBjaHJvbWl1bS5vcmc+Cgo+IC0tLQo+IAo+IENoYW5nZXMgaW4gdjM6
Cj4gLSBhZGQgYSBEV19NSVBJX05FRURTX0dSRl9DTEsgZm9yIFJLMzM5OQo+IAo+IENoYW5nZXMg
aW4gdjI6Cj4gLSBjaGVjayB0aGUgZ3JmX2NsayBvbmx5IGZvciBSSzMzOTkKPiAKPiAgZHJpdmVy
cy9ncHUvZHJtL3JvY2tjaGlwL2R3LW1pcGktZHNpLmMgfCAyNiArKysrKysrKysrKysrKysrKysr
KysrKysrLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjUgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigt
KQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvZHctbWlwaS1kc2ku
YyBiL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9kdy1taXBpLWRzaS5jCj4gaW5kZXggNjhmNDhi
MC4uNWExODI4MSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvZHctbWlw
aS1kc2kuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9kdy1taXBpLWRzaS5jCj4g
QEAgLTI1Miw2ICsyNTIsNyBAQAo+ICAjZGVmaW5lIFRIU19aRVJPX1BST0dSQU1fRU4JQklUKDYp
Cj4gIAo+ICAjZGVmaW5lIERXX01JUElfTkVFRFNfUEhZX0NGR19DTEsJQklUKDApCj4gKyNkZWZp
bmUgRFdfTUlQSV9ORUVEU19HUkZfQ0xLCQlCSVQoMSkKPiAgCj4gIGVudW0gewo+ICAJQkFOREdB
UF85N18wNywKPiBAQCAtMjk0LDYgKzI5NSw3IEBAIHN0cnVjdCBkd19taXBpX2RzaSB7Cj4gIAlz
dHJ1Y3QgcmVnbWFwICpncmZfcmVnbWFwOwo+ICAJdm9pZCBfX2lvbWVtICpiYXNlOwo+ICAKPiAr
CXN0cnVjdCBjbGsgKmdyZl9jbGs7Cj4gIAlzdHJ1Y3QgY2xrICpwbGxyZWZfY2xrOwo+ICAJc3Ry
dWN0IGNsayAqcGNsazsKPiAgCXN0cnVjdCBjbGsgKnBoeV9jZmdfY2xrOwo+IEBAIC05ODIsNiAr
OTg0LDE3IEBAIHN0YXRpYyB2b2lkIGR3X21pcGlfZHNpX2VuY29kZXJfZW5hYmxlKHN0cnVjdCBk
cm1fZW5jb2RlciAqZW5jb2RlcikKPiAgCWR3X21pcGlfZHNpX2RwaHlfaW50ZXJmYWNlX2NvbmZp
Zyhkc2kpOwo+ICAJZHdfbWlwaV9kc2lfY2xlYXJfZXJyKGRzaSk7Cj4gIAo+ICsJLyoKPiArCSAq
IEZvciB0aGUgUkszMzk5LCB0aGUgY2xrIG9mIGdyZiBtdXN0IGJlIGVuYWJsZWQgYmVmb3JlIHdy
aXRpbmcgZ3JmCj4gKwkgKiByZWdpc3Rlci4gQW5kIGZvciBSSzMyODggb3Igb3RoZXIgc29jLCB0
aGlzIGdyZl9jbGsgbXVzdCBiZSBOVUxMLAo+ICsJICogdGhlIGNsa19wcmVwYXJlX2VuYWJsZSBy
ZXR1cm4gdHJ1ZSBkaXJlY3RseS4KPiArCSAqLwo+ICsJcmV0ID0gY2xrX3ByZXBhcmVfZW5hYmxl
KGRzaS0+Z3JmX2Nsayk7Cj4gKwlpZiAocmV0KSB7Cj4gKwkJZGV2X2Vycihkc2ktPmRldiwgIkZh
aWxlZCB0byBlbmFibGUgZ3JmX2Nsa1xuIik7CgpuaXQ6IFByaW50IHJldD8KCj4gKwkJcmV0dXJu
Owo+ICsJfQo+ICsKPiAgCWlmIChwZGF0YS0+Z3JmX2RzaTBfbW9kZV9yZWcpCj4gIAkJcmVnbWFw
X3dyaXRlKGRzaS0+Z3JmX3JlZ21hcCwgcGRhdGEtPmdyZl9kc2kwX21vZGVfcmVnLAo+ICAJCQkg
ICAgIHBkYXRhLT5ncmZfZHNpMF9tb2RlKTsKPiBAQCAtMTAwNiw2ICsxMDE5LDggQEAgc3RhdGlj
IHZvaWQgZHdfbWlwaV9kc2lfZW5jb2Rlcl9lbmFibGUoc3RydWN0IGRybV9lbmNvZGVyICplbmNv
ZGVyKQo+ICAJcmVnbWFwX3dyaXRlKGRzaS0+Z3JmX3JlZ21hcCwgcGRhdGEtPmdyZl9zd2l0Y2hf
cmVnLCB2YWwpOwo+ICAJZGV2X2RiZyhkc2ktPmRldiwgInZvcCAlcyBvdXRwdXQgdG8gZHNpMFxu
IiwgKG11eCkgPyAiTElUIiA6ICJCSUciKTsKPiAgCWRzaS0+ZHBtc19tb2RlID0gRFJNX01PREVf
RFBNU19PTjsKPiArCj4gKwljbGtfZGlzYWJsZV91bnByZXBhcmUoZHNpLT5ncmZfY2xrKTsKPiAg
fQo+ICAKPiAgc3RhdGljIGludAo+IEBAIC0xMTM5LDcgKzExNTQsNyBAQCBzdGF0aWMgc3RydWN0
IGR3X21pcGlfZHNpX3BsYXRfZGF0YSByazMzOTlfbWlwaV9kc2lfZHJ2X2RhdGEgPSB7Cj4gIAku
Z3JmX3N3aXRjaF9yZWcgPSBSSzMzOTlfR1JGX1NPQ19DT04xOSwKPiAgCS5ncmZfZHNpMF9tb2Rl
ID0gUkszMzk5X0dSRl9EU0lfTU9ERSwKPiAgCS5ncmZfZHNpMF9tb2RlX3JlZyA9IFJLMzM5OV9H
UkZfU09DX0NPTjIyLAo+IC0JLmZsYWdzID0gRFdfTUlQSV9ORUVEU19QSFlfQ0ZHX0NMSywKPiAr
CS5mbGFncyA9IERXX01JUElfTkVFRFNfUEhZX0NGR19DTEsgfCBEV19NSVBJX05FRURTX0dSRl9D
TEssCj4gIAkubWF4X2RhdGFfbGFuZXMgPSA0LAo+ICB9Owo+ICAKPiBAQCAtMTI0MCw2ICsxMjU1
LDE1IEBAIHN0YXRpYyBpbnQgZHdfbWlwaV9kc2lfYmluZChzdHJ1Y3QgZGV2aWNlICpkZXYsIHN0
cnVjdCBkZXZpY2UgKm1hc3RlciwKPiAgCQl9Cj4gIAl9Cj4gIAo+ICsJaWYgKHBkYXRhLT5mbGFn
cyAmIERXX01JUElfTkVFRFNfR1JGX0NMSykgewo+ICsJCWRzaS0+Z3JmX2NsayA9IGRldm1fY2xr
X2dldChkZXYsICJncmYiKTsKPiArCQlpZiAoSVNfRVJSKGRzaS0+Z3JmX2NsaykpIHsKPiArCQkJ
cmV0ID0gUFRSX0VSUihkc2ktPmdyZl9jbGspOwo+ICsJCQlkZXZfZXJyKGRldiwgIlVuYWJsZSB0
byBnZXQgZ3JmX2NsazogJWRcbiIsIHJldCk7Cj4gKwkJCXJldHVybiByZXQ7Cj4gKwkJfQo+ICsJ
fQo+ICsKPiAgCXJldCA9IGNsa19wcmVwYXJlX2VuYWJsZShkc2ktPnBsbHJlZl9jbGspOwo+ICAJ
aWYgKHJldCkgewo+ICAJCWRldl9lcnIoZGV2LCAiJXM6IEZhaWxlZCB0byBlbmFibGUgcGxscmVm
X2Nsa1xuIiwgX19mdW5jX18pOwo+IC0tIAo+IDIuNi4zCj4gCj4gX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4g
ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0
b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgotLSAKU2VhbiBQYXVsLCBTb2Z0d2Fy
ZSBFbmdpbmVlciwgR29vZ2xlIC8gQ2hyb21pdW0gT1MKX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA
bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt
YW4vbGlzdGluZm8vZHJpLWRldmVsCg==