From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH] iommu/rockchip: Make use of 'struct iommu_device' Date: Mon, 3 Apr 2017 13:07:58 +0200 Message-ID: <20170403110758.GB4683@8bytes.org> References: <1490970624-19981-1-git-send-email-joro@8bytes.org> <1785458.LaVlbOJ67B@diego> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <1785458.LaVlbOJ67B@diego> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Heiko =?iso-8859-1?Q?St=FCbner?= Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Joerg Roedel , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-rockchip.vger.kernel.org Hey Heiko, On Mon, Apr 03, 2017 at 11:56:59AM +0200, Heiko St=FCbner wrote: > In general works, and I still keep a working iommu-based display :-) > I can also see my two vop iommus under /sys/class/iommu now. Great, thanks for testing that patch! > Links in the devices subdirectory do not work though, see below: Okay, thats bad, but I think its nothing we should work around right now. My goal with this work is to have a per-iommu check-device call-back to bind devices to iommus in the core code. This will also solve the probe-ordering issue and we are fine again. We just call check-device then for every device on the bus that has no iommu already when the iommu is registered and create the links at that time. Joerg