From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Norris Subject: Re: [PATCH v2 2/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver Date: Mon, 27 Nov 2017 21:24:02 -0800 Message-ID: <20171128052400.GA14640@google.com> References: <1511834125-7756-1-git-send-email-nickey.yang@rock-chips.com> <1511834125-7756-3-git-send-email-nickey.yang@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1511834125-7756-3-git-send-email-nickey.yang@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Nickey Yang Cc: mark.rutland@arm.com, hl@rock-chips.com, airlied@linux.ie, hoegsberg@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, philippe.cornu@st.com, yannick.fertre@st.com, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, zyw@rock-chips.com, xbl@rock-chips.com, mka@chromium.org, mark.yao@rock-chips.com List-Id: linux-rockchip.vger.kernel.org SGkgTmlja2V5LAoKVGhhbmtzIGZvciB0aGUgcXVpY2sgdmVyc2lvbiAyLiBZb3UndmUgZml4ZWQg bW9zdCBvZiB0aGUgdGhlIHByb2JsZW1zIEkKcG9pbnRlZCBvdXQsIGJ1dCB5b3UndmUgbWlzc2Vk IGF0IGxlYXN0IG9uZS4KCk9uIFR1ZSwgTm92IDI4LCAyMDE3IGF0IDA5OjU1OjI0QU0gKzA4MDAs IE5pY2tleSBZYW5nIHdyb3RlOgo+IEFkZCB0aGUgUk9DS0NISVAgRFNJIGNvbnRyb2xsZXIgZHJp dmVyIHRoYXQgdXNlcyB0aGUgU3lub3BzeXMgRGVzaWduV2FyZQo+IE1JUEkgRFNJIGhvc3QgY29u dHJvbGxlciBicmlkZ2UuCj4gCj4gU2lnbmVkLW9mZi1ieTogTmlja2V5IFlhbmcgPG5pY2tleS55 YW5nQHJvY2stY2hpcHMuY29tPgo+IC0tLQoKSSBzdXBwb3NlIHlvdSd2ZSBpbmNsdWRlZCBhIGNo YW5nZWxvZyBpbiB0aGUgY292ZXIgbGV0dGVyICh0aGFua3MhKSwgYnV0CnNvbWV0aW1lcyBpdCBo ZWxwcyB0byBnbyBoZXJlIHRvbywgdG8gZ2l2ZSBhbiBpbmRpdmlkdWFsIGhpc3Rvcnkgb2YgZWFj aApwYXRjaC4KCj4gIGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9LY29uZmlnICAgICAgICAgICAg ICAgIHwgICAgMiArLQo+ICBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvTWFrZWZpbGUgICAgICAg ICAgICAgICB8ICAgIDIgKy0KPiAgZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL2R3LW1pcGktZHNp LmMgICAgICAgICAgfCAxMzQ5IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1 L2RybS9yb2NrY2hpcC9kdy1taXBpLWRzaV9yb2NrY2hpcC5jIHwgIDc1NiArKysrKysrKysrKysr Cj4gIGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fZHJ2LmMgICAgIHwgICAg MiArLQo+ICBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX2Rydi5oICAgICB8 ICAgIDIgKy0KPiAgNiBmaWxlcyBjaGFuZ2VkLCA3NjAgaW5zZXJ0aW9ucygrKSwgMTM1MyBkZWxl dGlvbnMoLSkKPiAgZGVsZXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9k dy1taXBpLWRzaS5jCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL2dwdS9kcm0vcm9ja2No aXAvZHctbWlwaS1kc2lfcm9ja2NoaXAuYwo+IAoKCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9yb2NrY2hpcC9kdy1taXBpLWRzaV9yb2NrY2hpcC5jIGIvZHJpdmVycy9ncHUvZHJtL3Jv Y2tjaGlwL2R3LW1pcGktZHNpX3JvY2tjaGlwLmMKPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+IGlu ZGV4IDAwMDAwMDAuLmM5MTlkNGYKPiAtLS0gL2Rldi9udWxsCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL3JvY2tjaGlwL2R3LW1pcGktZHNpX3JvY2tjaGlwLmMKPiBAQCAtMCwwICsxLDc1NiBAQApb Li4uXQo+ICtzdGF0aWMgaW50IGR3X21pcGlfZHNpX3JvY2tjaGlwX2JpbmQoc3RydWN0IGRldmlj ZSAqZGV2LAo+ICsJCQkJICAgICBzdHJ1Y3QgZGV2aWNlICptYXN0ZXIsCj4gKwkJCQkgICAgIHZv aWQgKmRhdGEpCj4gK3sKPiArCWNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQgKm9mX2lkID0KPiAr CQkJb2ZfbWF0Y2hfZGV2aWNlKGR3X21pcGlfZHNpX3JvY2tjaGlwX2R0X2lkcywgZGV2KTsKPiAr CWNvbnN0IHN0cnVjdCByb2NrY2hpcF9kd19kc2lfY2hpcF9kYXRhICpjZGF0YSA9IG9mX2lkLT5k YXRhOwo+ICsJc3RydWN0IGR3X21pcGlfZHNpX3JvY2tjaGlwICpkc2kgPSBkZXZfZ2V0X2RydmRh dGEoZGV2KTsKCkhtbSwgc28gSSBzZWUgMiBpbnN0YW5jZXMgb2YgJ2Rldl9nZXRfZHJ2ZGF0YSgp JyBpbiB0aGlzIGRyaXZlciwgYW5kIG9uZQpvZiB0aGVtIGlzIGhlcmUuIEkgbmV2ZXIgc2VlIGEg J2Rldl9zZXRfZHJ2ZGF0YSgpJywgc28gdGhhdCBjYW4ndApwb3NzaWJseSBiZSB1c2VmdWwuCgpJ biB0aGlzIGNhc2UuLi55b3UndmUgYWN0dWFsbHkgbW92ZWQgYWxsIHRoZSAncHJvYmUoKScgbG9n aWMgaW50bwpiaW5kKCksIHNvIHRoZXJlJ3Mgbm8gZHJpdmVyIGRhdGEgdG8gY2Fycnkgb3ZlciBo ZXJlLiBBbmQgaW5zdGVhZCwgeW91Cmp1c3QgY2xvYmJlciB0aGlzICdkc2kgPSAuLi4nIGFzc2ln bm1lbnQgYSBmZXcgbGluZXMgYmVsb3c6Cgo+ICsJc3RydWN0IHJlc291cmNlICpyZXM7Cj4gKwlz dHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2ID0gdG9fcGxhdGZvcm1fZGV2aWNlKGRldik7Cj4g KwlzdHJ1Y3QgZHJtX2RldmljZSAqZHJtX2RldiA9IGRhdGE7Cj4gKwlzdHJ1Y3QgZGV2aWNlX25v ZGUgKm5wID0gZGV2LT5vZl9ub2RlOwo+ICsJaW50IHJldDsKPiArCj4gKwlkc2kgPSBkZXZtX2t6 YWxsb2MoZGV2LCBzaXplb2YoKmRzaSksIEdGUF9LRVJORUwpOwoKXl5eIFNlZSBoZXJlLgoKU28g aWYgeW91IGRvbid0IGFjdHVhbGx5IG5lZWQgdG8gc3Rhc2ggYW55dGhpbmcgaW4gZHJ2ZGF0YSBi ZXR3ZWVuCnByb2JlKCkgYW5kIGJpbmQoKSwgdGhlbiB5b3UgbWlnaHQgZ2V0IGF3YXkgd2l0aG91 dCBteSBwYXRjaDoKCltQQVRDSF0gZHJtL2JyaWRnZS9zeW5vcHNpczogc3RvcCBjbG9iYmVyaW5n IGRydmRhdGEKaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wYXRjaC8xMDA3ODQ5My8KClRo ZXJlJ3Mgb25lIG90aGVyIGluc3RhbmNlIHRvIHJldmlldyB0aG91Z2g6Cgo+ICsJaWYgKCFkc2kp Cj4gKwkJcmV0dXJuIC1FTk9NRU07Cj4gKwpbLi4uXQoKPiArc3RhdGljIHZvaWQgZHdfbWlwaV9k c2lfcm9ja2NoaXBfdW5iaW5kKHN0cnVjdCBkZXZpY2UgKmRldiwKPiArCQkJCQlzdHJ1Y3QgZGV2 aWNlICptYXN0ZXIsCj4gKwkJCQkJdm9pZCAqZGF0YSkKPiArewo+ICsJc3RydWN0IGR3X21pcGlf ZHNpX3JvY2tjaGlwICpkc2kgPSBkZXZfZ2V0X2RydmRhdGEoZGV2KTsKCl5eIFRoYXQncyB3cm9u Zy4gWW91IGVpdGhlciB3YW50IHRvIGRvIHlvdXIgb3duICdkZXZfc2V0X2RydmRhdGEoKScKc29t ZXdoZXJlIChhbmQgbWFrZSBzdXJlIHRoZSBicmlkZ2UgZHJpdmVyIGRvZXNuJ3QgY2xvYmJlciBp dCwgZS5nLiwKd2l0aCBteSBwYXRjaCBhYm92ZSksIG9yIGVsc2UgeW91IG5lZWQgdG8gY29udmlu Y2UgdGhlIGJyaWRnZSBkcml2ZXIgdG8KZ2l2ZSB1cyBiYWNrIHNvbWV0aGluZyBsaWtlIGl0cyAn cHJpdl9kYXRhJyBwb2ludGVyCihkc2ktPnBsYXRfZGF0YS0+cHJpdl9kYXRhKS4KCkFsc28sIGRv bid0IHlvdSBuZWVkIHRvIGNhbGwgZHdfbWlwaV9kc2lfdW5iaW5kKCkgaGVyZT8KCj4gKwljbGtf ZGlzYWJsZV91bnByZXBhcmUoZHNpLT5wbGxyZWZfY2xrKTsKPiArfQo+ICsKPiArc3RhdGljIGNv bnN0IHN0cnVjdCBjb21wb25lbnRfb3BzIGR3X21pcGlfZHNpX3JvY2tjaGlwX29wcyA9IHsKPiAr CS5iaW5kCT0gZHdfbWlwaV9kc2lfcm9ja2NoaXBfYmluZCwKPiArCS51bmJpbmQJPSBkd19taXBp X2RzaV9yb2NrY2hpcF91bmJpbmQsCj4gK307CgouLi4KCkJyaWFuCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=