From: Brian Norris <briannorris@chromium.org>
To: Nickey Yang <nickey.yang@rock-chips.com>
Cc: mark.rutland@arm.com, airlied@linux.ie, hoegsberg@gmail.com,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
philippe.cornu@st.com, yannick.fertre@st.com,
linux-rockchip@lists.infradead.org, robh+dt@kernel.org,
laurent.pinchart@ideasonboard.com, zyw@rock-chips.com,
xbl@rock-chips.com, mka@chromium.org, hl@rock-chips.com
Subject: Re: [PATCH v6 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata
Date: Wed, 6 Dec 2017 13:39:00 -0800 [thread overview]
Message-ID: <20171206213858.GA14257@google.com> (raw)
In-Reply-To: <1512551301-12946-2-git-send-email-nickey.yang@rock-chips.com>
On Wed, Dec 06, 2017 at 05:08:19PM +0800, Nickey Yang wrote:
> From: Brian Norris <briannorris@chromium.org>
>
> Bridge drivers/helpers shouldn't be clobbering the drvdata, since a
> parent driver might need to own this. Instead, let's return our
> 'dw_mipi_dsi' object and have callers pass that back to us for removal.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> Signed-off-by: Nickey Yang <nickey.yang@rock-chips.com>
> Link:https://patchwork.kernel.org/patch/10078493/
>
> ---
> Changes
>
> v4:
> - Add From tag,update subject line
> - keep patch "drm/stm: dsi: Adjust dw_mipi_dsi_probe and remove"
> in this piece together.
>
> v5:
> - remove Review & Ack tag
> - fix remove() directly referencing the static
> dw_mipi_dsi_stm_plat_data struct.
You've gotten this back into basically the shape I sent v1 in, so I
guess this deserves an:
Acked-by: Brian Norris <briannorris@chromium.org>
:)
Only net changes: you renamed the 'dsi' field to 'dmd' (Dwc Mipi
Device?), and my 'return 0' changed back to the original 'return ret' at
the end of probe(). Doesn't make any functional difference, so fine with
me.
If everybody's just as happy with this as with the first
version...should it just be applied now, regardless of the status of the
next 2 patches? Could help reduce the discussion (and confusion)
surface.
Regards,
Brian
> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 36 ++++++++++-----------------
> drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 10 +++++---
> include/drm/bridge/dw_mipi_dsi.h | 17 ++++++++-----
> 3 files changed, 30 insertions(+), 33 deletions(-)
...
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-12-06 21:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 9:08 [PATCH v6 0/3] Update ROCKCHIP DSI driver that uses dw-mipi-dsi bridge Nickey Yang
2017-12-06 9:08 ` [PATCH v6 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata Nickey Yang
2017-12-06 21:39 ` Brian Norris [this message]
2017-12-07 11:41 ` Philippe CORNU
2017-12-07 17:24 ` Brian Norris
2017-12-06 9:08 ` [PATCH v6 2/3] dt-bindings: display: rockchip: update DSI controller Nickey Yang
2017-12-06 9:08 ` [PATCH v6 3/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver Nickey Yang
2017-12-06 21:52 ` Brian Norris
2017-12-07 14:29 ` Philippe CORNU
2017-12-12 1:42 ` Nickey Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171206213858.GA14257@google.com \
--to=briannorris@chromium.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=hl@rock-chips.com \
--cc=hoegsberg@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=nickey.yang@rock-chips.com \
--cc=philippe.cornu@st.com \
--cc=robh+dt@kernel.org \
--cc=xbl@rock-chips.com \
--cc=yannick.fertre@st.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).