From: John Keeping <john@metanate.com>
To: Mark Brown <broonie@kernel.org>
Cc: Sugar Zhang <sugar.zhang@rock-chips.com>,
linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: rockchip: i2s: fix playback after runtime resume
Date: Mon, 8 Jan 2018 15:59:06 +0000 [thread overview]
Message-ID: <20180108155906.19fe98a2.john@metanate.com> (raw)
In-Reply-To: <20180108152641.GF11698@sirena.org.uk>
On Mon, 8 Jan 2018 15:26:41 +0000, Mark Brown wrote:
> On Mon, Jan 08, 2018 at 12:23:01PM +0000, John Keeping wrote:
>
> > @@ -527,6 +531,7 @@ static bool rockchip_i2s_volatile_reg(struct device *dev, unsigned int reg)
> > static bool rockchip_i2s_precious_reg(struct device *dev, unsigned int reg)
> > {
> > switch (reg) {
> > + case I2S_RXDR:
> > default:
> > return false;
> > }
>
> This doesn't look right?
No, it's not, it should be "return true;" for I2S_RXDR.
next prev parent reply other threads:[~2018-01-08 15:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 12:23 [PATCH] ASoC: rockchip: i2s: fix playback after runtime resume John Keeping
2018-01-08 15:26 ` Mark Brown
2018-01-08 15:59 ` John Keeping [this message]
2018-01-08 16:01 ` [PATCH v2] " John Keeping
2018-01-08 16:22 ` Applied "ASoC: rockchip: i2s: fix playback after runtime resume" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180108155906.19fe98a2.john@metanate.com \
--to=john@metanate.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-rockchip@lists.infradead.org \
--cc=sugar.zhang@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox