From: Philippe Cornu <philippe.cornu@st.com>
To: Archit Taneja <architt@codeaurora.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
David Airlie <airlied@linux.ie>,
Philippe Cornu <philippe.cornu@st.com>,
Brian Norris <briannorris@chromium.org>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Bhumika Goyal <bhumirks@gmail.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Sandy Huang <hjc@rock-chips.com>, Heiko Stubner <heiko@sntech.de>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Cc: Alexandre Torgue <alexandre.torgue@st.com>,
Yannick Fertre <yannick.fertre@st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Mickael Reulier <mickael.reulier@st.com>,
Vincent Abriou <vincent.abriou@st.com>,
Ludovic Barre <ludovic.barre@st.com>
Subject: [PATCH v1 2/2] drm/bridge/synopsys: dsi: Add a warning msg on dsi read operations
Date: Tue, 23 Jan 2018 15:26:18 +0100 [thread overview]
Message-ID: <20180123142618.28384-3-philippe.cornu@st.com> (raw)
In-Reply-To: <20180123142618.28384-1-philippe.cornu@st.com>
The DCS/GENERIC DSI read feature is not yet implemented so it
is important to warn the host_transfer() caller in case of
read operation requests.
Signed-off-by: Philippe Cornu <philippe.cornu@st.com>
---
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
index 096cf5e5bb30..e46ddff8601c 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
@@ -417,7 +417,14 @@ static ssize_t dw_mipi_dsi_host_transfer(struct mipi_dsi_host *host,
if (ret)
return ret;
- nb_bytes = packet.size;
+ if (msg->rx_buf && msg->rx_len > 0) {
+ /* TODO dw drv improvements: implement read feature */
+ dev_warn(dsi->dev, "read operations not yet implemented\n");
+ return -EPERM;
+
+ } else {
+ nb_bytes = packet.size;
+ }
return nb_bytes;
}
--
2.15.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-01-23 14:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 14:26 [PATCH v1 0/2] drm/bridge/synopsys: dsi: Add fix & warning in dsi_host_transfer() Philippe Cornu
2018-01-23 14:26 ` [PATCH v1 1/2] drm/bridge/synopsys: dsi: Fix dsi_host_transfer() return value Philippe Cornu
2018-01-23 21:38 ` Brian Norris
2018-01-24 13:33 ` Philippe CORNU
[not found] ` <4a1b0208-3187-2f08-69fe-ca3b77ee88a8-qxv4g6HH51o@public.gmane.org>
2018-01-24 18:37 ` Brian Norris
2018-01-25 12:16 ` Andrzej Hajda
2018-01-25 22:51 ` Brian Norris
2018-01-23 14:26 ` Philippe Cornu [this message]
2018-01-23 21:28 ` [PATCH v1 2/2] drm/bridge/synopsys: dsi: Add a warning msg on dsi read operations Brian Norris
2018-01-24 13:22 ` Philippe CORNU
2018-01-24 18:14 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180123142618.28384-3-philippe.cornu@st.com \
--to=philippe.cornu@st.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=alexandre.torgue@st.com \
--cc=architt@codeaurora.org \
--cc=benjamin.gaignard@linaro.org \
--cc=bhumirks@gmail.com \
--cc=briannorris@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=ludovic.barre@st.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mickael.reulier@st.com \
--cc=vincent.abriou@st.com \
--cc=yannick.fertre@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox