Linux-Rockchip Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jeffy Chen <jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Jeffy Chen <jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	jcliang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Subject: [PATCH v7 06/14] iommu/rockchip: Fix TLB flush of secondary IOMMUs
Date: Tue,  6 Mar 2018 11:21:05 +0800	[thread overview]
Message-ID: <20180306032113.22247-3-jeffy.chen@rock-chips.com> (raw)
In-Reply-To: <20180306032113.22247-1-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>

From: Tomasz Figa <tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>

Due to the bug in current code, only first IOMMU has the TLB lines
flushed in rk_iommu_zap_lines. This patch fixes the inner loop to
execute for all IOMMUs and properly flush the TLB.

Signed-off-by: Tomasz Figa <tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Signed-off-by: Jeffy Chen <jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
---

Changes in v7: None
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None

 drivers/iommu/rockchip-iommu.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c
index baba283ccdf9..c4131ca792e0 100644
--- a/drivers/iommu/rockchip-iommu.c
+++ b/drivers/iommu/rockchip-iommu.c
@@ -274,19 +274,21 @@ static void rk_iommu_base_command(void __iomem *base, u32 command)
 {
 	writel(command, base + RK_MMU_COMMAND);
 }
-static void rk_iommu_zap_lines(struct rk_iommu *iommu, dma_addr_t iova,
+static void rk_iommu_zap_lines(struct rk_iommu *iommu, dma_addr_t iova_start,
 			       size_t size)
 {
 	int i;
-
-	dma_addr_t iova_end = iova + size;
+	dma_addr_t iova_end = iova_start + size;
 	/*
 	 * TODO(djkurtz): Figure out when it is more efficient to shootdown the
 	 * entire iotlb rather than iterate over individual iovas.
 	 */
-	for (i = 0; i < iommu->num_mmu; i++)
-		for (; iova < iova_end; iova += SPAGE_SIZE)
+	for (i = 0; i < iommu->num_mmu; i++) {
+		dma_addr_t iova;
+
+		for (iova = iova_start; iova < iova_end; iova += SPAGE_SIZE)
 			rk_iommu_write(iommu->bases[i], RK_MMU_ZAP_ONE_LINE, iova);
+	}
 }
 
 static bool rk_iommu_is_stall_active(struct rk_iommu *iommu)
-- 
2.11.0

  parent reply	other threads:[~2018-03-06  3:21 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-06  3:02 [PATCH v7 00/14] iommu/rockchip: Use OF_IOMMU Jeffy Chen
     [not found] ` <20180306030252.3197-1-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-03-06  3:02   ` [PATCH v7 01/14] iommu/rockchip: Prohibit unbind and remove Jeffy Chen
2018-03-07 12:55     ` Robin Murphy
2018-03-06  3:02   ` [PATCH v7 02/14] iommu/rockchip: Fix error handling in probe Jeffy Chen
     [not found]     ` <20180306030252.3197-3-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-03-07 12:59       ` Robin Murphy
2018-03-06  3:02   ` [PATCH v7 03/14] iommu/rockchip: Request irqs in rk_iommu_probe() Jeffy Chen
     [not found]     ` <20180306030252.3197-4-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-03-07 13:00       ` Robin Murphy
2018-03-06  3:21   ` [PATCH v7 04/14] iommu/rockchip: Fix error handling in attach Jeffy Chen
     [not found]     ` <20180306032113.22247-1-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-03-06  3:21       ` [PATCH v7 05/14] iommu/rockchip: Use iopoll helpers to wait for hardware Jeffy Chen
2018-03-06  3:21       ` Jeffy Chen [this message]
2018-03-06  3:21       ` [PATCH v7 08/14] iommu/rockchip: Control clocks needed to access the IOMMU Jeffy Chen
2018-03-06  3:21     ` [PATCH v7 07/14] ARM: dts: rockchip: add clocks in iommu nodes Jeffy Chen
2018-03-06  3:21     ` [PATCH v7 09/14] dt-bindings: iommu/rockchip: Add clock property Jeffy Chen
     [not found]       ` <20180306032113.22247-6-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-03-07 13:01         ` Robin Murphy
2018-03-06  3:27   ` [PATCH v7 10/14] iommu/rockchip: Use IOMMU device for dma mapping operations Jeffy Chen
     [not found]     ` <20180306032759.29069-1-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-03-06  3:27       ` [PATCH v7 11/14] iommu/rockchip: Use OF_IOMMU to attach devices automatically Jeffy Chen
2018-03-06  3:27       ` [PATCH v7 12/14] iommu/rockchip: Fix error handling in init Jeffy Chen
2018-03-06  3:27       ` [PATCH v7 13/14] iommu/rockchip: Add runtime PM support Jeffy Chen
     [not found]         ` <20180306032759.29069-4-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-03-06 10:07           ` Tomasz Figa
     [not found]             ` <CAAFQd5DPewKda7ThqMGKRvnArZ0X8ChD10E06nLZaNa-SBNdwA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-03-07  3:16               ` JeffyChen
2018-03-07  3:26                 ` Tomasz Figa
2018-03-07  3:24             ` Tomasz Figa
2018-03-06  3:27     ` [PATCH v7 14/14] iommu/rockchip: Support sharing IOMMU between masters Jeffy Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180306032113.22247-3-jeffy.chen@rock-chips.com \
    --to=jeffy.chen-tnx95d0mmh7dzftrwevzcw@public.gmane.org \
    --cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=jcliang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox