From: Sean Paul <sean@poorly.run>
To: Heiko Stuebner <heiko@sntech.de>
Cc: linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/rockchip: rgb: add stub functions when rgb encoder is disabled
Date: Wed, 5 Sep 2018 15:45:09 -0400 [thread overview]
Message-ID: <20180905194509.GX188300@art_vandelay> (raw)
In-Reply-To: <20180905193356.GW188300@art_vandelay>
On Wed, Sep 05, 2018 at 03:33:56PM -0400, Sean Paul wrote:
> On Wed, Sep 05, 2018 at 09:13:02PM +0200, Heiko Stuebner wrote:
> > The newly added internal rgb encoder for Rockchip vops is missing
> > stubs for the case that the rgb output part is not enabled in the
> > kernel config. So add these.
> >
> > Fixes: 1f0f01515172 ("drm/rockchip: Add support for Rockchip Soc RGB output interface")
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > ---
> > drivers/gpu/drm/rockchip/rockchip_rgb.h | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/rockchip/rockchip_rgb.h b/drivers/gpu/drm/rockchip/rockchip_rgb.h
> > index c712a673d1e3..bcd903688491 100644
> > --- a/drivers/gpu/drm/rockchip/rockchip_rgb.h
> > +++ b/drivers/gpu/drm/rockchip/rockchip_rgb.h
> > @@ -14,7 +14,21 @@
> > * GNU General Public License for more details.
> > */
> >
> > +#ifdef CONFIG_ROCKCHIP_RGB
> > struct rockchip_rgb *rockchip_rgb_init(struct device *dev,
> > struct drm_crtc *crtc,
> > struct drm_device *drm_dev);
> > void rockchip_rgb_fini(struct rockchip_rgb *rgb);
> > +#else
> > +static inline struct rockchip_rgb *rockchip_rgb_init(struct device *dev,
> > + struct drm_crtc *crtc,
> > + struct drm_device *drm_dev)
> > +{
> > + return NULL;
> > +}
> > +
> > +static inline void rockchip_rgb_fini(struct rockchip_rgb *rgb)
> > +{
> > + return;
>
> This return is redundant. With that nit fixed, feel free to commit with
>
> Reviewed-by: Sean Paul <seanpaul@chromium.org>
I went ahead and applied this myself since I'm prepping a pull request.
Thanks for the quick fix.
Sean
>
>
> > +}
> > +#endif
> > --
> > 2.17.0
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Sean Paul, Software Engineer, Google / Chromium OS
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2018-09-05 19:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 19:13 [PATCH] drm/rockchip: rgb: add stub functions when rgb encoder is disabled Heiko Stuebner
2018-09-05 19:33 ` Sean Paul
2018-09-05 19:45 ` Sean Paul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180905194509.GX188300@art_vandelay \
--to=sean@poorly.run \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox