public inbox for linux-rockchip@lists.infradead.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org
Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: [PATCH v4 0/2] Reworked rk3288-tinker-s devicetree
Date: Sun, 23 Sep 2018 13:38:05 +0200	[thread overview]
Message-ID: <20180923113807.11558-1-heiko@sntech.de> (raw)

Hi David,

I've adpated your patches 1+2 like so and would like to add them this way
later on. Biggest change is of course making patch 1 solely about moving
the shared parts to the dtsi and adding the tinker-s.dts including the
emmc in the second patch.

Apart from that you can also see some previously missing style-related
fixes. For example patch subject lines are somewhat specific, to allow
people browsing the git history to realize the core patch contents just
from the "headline" and also use the "correct" prefixes which vary
depending on the subsystem your changing.

For future patches you can just do a "git log --oneline arch/arm/boot/dts"
(change directory depending on location of the change of course), to
see that arm32 dts use "ARM: dts: $soc-vendor: foo".


Also providing a commit message describing the individual change
in a bit more detail is important.

The wifi patch is a different issue, so I'll reply there.


Heiko

David Summers (2):
  ARM: dts: rockchip: move shared tinker-board nodes to a common dtsi
  ARM: dts: rockchip: add rk3288-based Tinker board S

 .../devicetree/bindings/arm/rockchip.txt      |   4 +
 arch/arm/boot/dts/Makefile                    |   1 +
 arch/arm/boot/dts/rk3288-tinker-s.dts         |  26 +
 arch/arm/boot/dts/rk3288-tinker.dts           | 498 +----------------
 arch/arm/boot/dts/rk3288-tinker.dtsi          | 504 ++++++++++++++++++
 5 files changed, 537 insertions(+), 496 deletions(-)
 create mode 100644 arch/arm/boot/dts/rk3288-tinker-s.dts
 create mode 100644 arch/arm/boot/dts/rk3288-tinker.dtsi

-- 
2.18.0

             reply	other threads:[~2018-09-23 11:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-23 11:38 Heiko Stuebner [this message]
2018-09-23 11:38 ` [PATCH v4 1/2] ARM: dts: rockchip: move shared tinker-board nodes to a common dtsi Heiko Stuebner
     [not found] ` <20180923113807.11558-1-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2018-09-23 11:38   ` [PATCH v4 2/2] ARM: dts: rockchip: add rk3288-based Tinker board S Heiko Stuebner
     [not found]     ` <20180923113807.11558-3-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2018-09-27 18:24       ` Rob Herring
2018-09-23 16:44   ` [PATCH v4 0/2] Reworked rk3288-tinker-s devicetree David Summers
2018-09-26 12:32   ` Heiko Stuebner
2018-10-06 12:54   ` David Summers
     [not found]     ` <5dc8cdc9-20d5-bafa-3693-67ec09577234-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org>
2018-10-08  9:32       ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180923113807.11558-1-heiko@sntech.de \
    --to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
    --cc=beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox