Re: [PATCH] arm64: dts: Remove inconsistent use of 'arm,armv8' compatible string

Richter, Robert
2019-01-10T14:45:51Z

Rob,

On 09.01.19 14:29:34, Rob Herring wrote:
> External Email
>
> The 'arm,armv8' compatible string is only for software models. It adds
> little value otherwise and is inconsistently used as a fallback on some
> platforms. Remove it from those platforms.
>
> This fixes warnings generated by the DT schema.
>
> Reported-by: Michal Simek <michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
> Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
> Cc: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
> Signed-off-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> ---
> armsoc folks, Please apply directly.

> diff --git a/arch/arm64/boot/dts/cavium/thunder2-99xx.dtsi b/arch/arm64/boot/dts/cavium/thunder2-99xx.dtsi
> index ff5c4c47b22b..c616132f7d6d 100644
> --- a/arch/arm64/boot/dts/cavium/thunder2-99xx.dtsi
> +++ b/arch/arm64/boot/dts/cavium/thunder2-99xx.dtsi
> @@ -27,28 +27,28 @@
>
> cpu@0 {
> device_type = "cpu";
> - compatible = "cavium,thunder2", "brcm,vulcan", "arm,armv8";
> + compatible = "cavium,thunder2";

We are just checking if removing the "brcm,vulcan" string has any
impact on early silicon revisions we want to support (see also
BRCM_CPU_PART_VULCAN).

Maybe you make this a separate change?

-Robert

> reg = <0x0 0x0>;
> enable-method = "psci";
> };