Re: [PATCH] arm64: dts: Remove inconsistent use of 'arm,armv8' compatible string

Tero Kristo
2019-01-10T12:02:12Z

On 10/01/2019 04:27, Nishanth Menon wrote:
> On 14:29-20190109, Rob Herring wrote:
>> The 'arm,armv8' compatible string is only for software models. It adds
>> little value otherwise and is inconsistently used as a fallback on some
>> platforms. Remove it from those platforms.
>>
>> This fixes warnings generated by the DT schema.
>>
>> Reported-by: Michal Simek <michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
>> Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
>> Cc: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
>> Signed-off-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>> ---
> [...]
>
> ARM SoC maintainers, At least on a quick look (I could be wrong), I
> think we don't have any explicit processor bindings documentation.
>
> However, most of SoC folks seem to key off matches else where I
> guess..
>
> Not sure, while at this, you if you are planning on fixing up
> Documentation/devicetree/bindings/arm/arm-boards:
> compatible = "arm,cortex-a53","arm,armv8";
> Documentation/devicetree/bindings/arm/cpu-capacity.txt:
> compatible = "arm,cortex-a53","arm,armv8";
>
> Anyways, for TI SoC:
>
>> arch/arm64/boot/dts/ti/k3-am654.dtsi | 8 +-
>> diff --git a/arch/arm64/boot/dts/ti/k3-am654.dtsi b/arch/arm64/boot/dts/ti/k3-am654.dtsi
>> index 2affa6f6617e..b221abf43ac2 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am654.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am654.dtsi
>> @@ -34,7 +34,7 @@
>> };
>>
>> cpu0: cpu@0 {
>> - compatible = "arm,cortex-a53", "arm,armv8";
>> + compatible = "arm,cortex-a53";
>> reg = <0x000>;
>> device_type = "cpu";
>> enable-method = "psci";
>> @@ -48,7 +48,7 @@
>> };
>>
>> cpu1: cpu@1 {
>> - compatible = "arm,cortex-a53", "arm,armv8";
>> + compatible = "arm,cortex-a53";
>> reg = <0x001>;
>> device_type = "cpu";
>> enable-method = "psci";
>> @@ -62,7 +62,7 @@
>> };
>>
>> cpu2: cpu@100 {
>> - compatible = "arm,cortex-a53", "arm,armv8";
>> + compatible = "arm,cortex-a53";
>> reg = <0x100>;
>> device_type = "cpu";
>> enable-method = "psci";
>> @@ -76,7 +76,7 @@
>> };
>>
>> cpu3: cpu@101 {
>> - compatible = "arm,cortex-a53", "arm,armv8";
>> + compatible = "arm,cortex-a53";
>> reg = <0x101>;
>> device_type = "cpu";
>> enable-method = "psci";
>
> Acked-by: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
>

TI portion looks fine to me also, so:

Acked-by: Tero Kristo <t-kristo-l0cyMroinI0@public.gmane.org>

-Tero
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki