From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Wen Yang" <wen.yang99@zte.com.cn>,
"Andreas Färber" <afaerber@suse.de>,
"Liviu Dudau" <liviu.dudau@arm.com>,
"Sudeep Holla" <sudeep.holla@arm.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Russell King" <linux@armlinux.org.uk>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Kukjin Kim" <kgene@kernel.org>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
"Michal Simek" <michal.simek@xilinx.com>,
"Dinh Nguyen" <dinguyen@kernel.org>,
"Heiko Stübner" <heiko@sntech.de>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Ray Jui" <rjui@broadcom.com>
Subject: Re: [PATCH 01/15] ARM: actions: fix a leaked reference by addingmissing of_node_put
Date: Mon, 4 Mar 2019 20:18:29 +0530 [thread overview]
Message-ID: <20190304144829.GA5265@Mani-XPS-13-9360> (raw)
In-Reply-To: <CACRpkdb=E9_rm4_7DQV3dS5uOs1gozxEwN9MtWr0tTwmjcYe=A@mail.gmail.com>
Hi Linus,
On Mon, Mar 04, 2019 at 01:29:33PM +0100, Linus Walleij wrote:
> On Fri, Mar 1, 2019 at 4:55 PM Manivannan Sadhasivam
> <manivannan.sadhasivam@linaro.org> wrote:
> > Hi Wen,
> >
> > On Fri, Mar 01, 2019 at 04:56:42PM +0800, Wen Yang wrote:
> > > The call to of_get_next_child returns a node pointer with refcount
> > > incremented thus it must be explicitly decremented after the last
> > > usage.
> > >
> > > Detected by coccinelle with the following warnings:
> > > ./arch/arm/mach-actions/platsmp.c:112:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 103, but without a corresponding object release within this function.
> > > ./arch/arm/mach-actions/platsmp.c:124:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 115, but without a corresponding object release within this function.
> > > ./arch/arm/mach-actions/platsmp.c:137:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 128, but without a corresponding object release within this function.
> > >
> >
> > We have a floating patch for this:
> > https://www.spinics.net/lists/arm-kernel/msg694544.html
> >
> > Andreas: Can you please take a second look at the patchset submitted by Linus
> > Walleij and Russel for simplifying the Actions startup code?
>
> Andreas wrote a version of simplifying secondary startup in the
> same spirit as Russell's patches, and it's merged and all
> is fine I think.
>
Oops. I think I missed that! Can you please point me to that patch? And how it
got merged? I did the PR for actions stuff this time and haven't included any
mach-actions patches.
Thanks,
Mani
> If this patch applied on top of the current upstream code I'd say
> just forget about my patch and merge Wen's patch instead.
>
> Yours,
> Linus Walleij
next prev parent reply other threads:[~2019-03-04 14:48 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 8:56 [PATCH 01/15] ARM: actions: fix a leaked reference by addingmissing of_node_put Wen Yang
2019-03-01 8:56 ` [PATCH 02/15] ARM: bcm: " Wen Yang
2019-03-01 18:28 ` Florian Fainelli
2019-03-01 8:56 ` [PATCH 03/15] ARM: exynos: " Wen Yang
2019-03-01 9:14 ` Krzysztof Kozlowski
2019-03-01 8:56 ` [PATCH 04/15] ARM: hisi: " Wen Yang
2019-03-01 8:56 ` [PATCH 05/15] ARM: imx51: " Wen Yang
2019-03-04 5:37 ` Shawn Guo
2019-03-01 8:56 ` [PATCH 06/15] arm: npcm: " Wen Yang
2019-03-04 15:39 ` Avi Fishman
2019-03-01 8:56 ` [PATCH 07/15] ARM: rockchip: " Wen Yang
2019-03-01 8:56 ` [PATCH 08/15] ARM: shmobile: " Wen Yang
2019-03-01 9:51 ` Geert Uytterhoeven
2019-03-04 10:24 ` Simon Horman
2019-03-04 10:55 ` Fabrizio Castro
2019-03-06 13:00 ` Simon Horman
2019-03-01 8:56 ` [PATCH 09/15] ARM: socfpga: " Wen Yang
2019-03-01 8:56 ` [PATCH 10/15] ARM: sunxi: " Wen Yang
2019-03-01 8:56 ` [PATCH 11/15] ARM: versatile: " Wen Yang
2019-03-01 13:30 ` Linus Walleij
2019-03-01 8:56 ` [PATCH 12/15] ARM: vexpress: " Wen Yang
2019-03-04 14:46 ` Sudeep Holla
2019-03-01 8:56 ` [PATCH 13/15] ARM: zynq: " Wen Yang
2019-03-01 8:56 ` [PATCH 14/15] arm64: cpu_ops: " Wen Yang
2019-03-01 8:56 ` [PATCH 15/15] ARM: axxia: " Wen Yang
2019-03-01 15:55 ` [PATCH 01/15] ARM: actions: " Manivannan Sadhasivam
2019-03-04 12:29 ` Linus Walleij
2019-03-04 14:48 ` Manivannan Sadhasivam [this message]
2019-03-04 22:37 ` Linus Walleij
[not found] ` <CAOZjjhnDYHkWCd-zDqkFpg5FPoj-UxxNwVxfbg6QEahiASm10w@mail.gmail.com>
2019-03-05 9:55 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304144829.GA5265@Mani-XPS-13-9360 \
--to=manivannan.sadhasivam@linaro.org \
--cc=afaerber@suse.de \
--cc=dinguyen@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=heiko@sntech.de \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=liviu.dudau@arm.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=michal.simek@xilinx.com \
--cc=rjui@broadcom.com \
--cc=sudeep.holla@arm.com \
--cc=wen.yang99@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox