Re: [PATCH v3 14/15] rockchip/vpu: Add support for MPEG-2 decoding

[Boris Brezillon <boris.brezillon-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>]

On Mon, 22 Apr 2019 14:59:17 +0000
Jonas Karlman <jonas-uIzNG4q0ceqzQB+pC5nmwQ@public.gmane.org> wrote:

> On 2019-04-22 10:08, Boris Brezillon wrote:
> > From: Ezequiel Garcia <ezequiel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>  
> 
> Please restore my commit authorship, it seems to have changed in v3.

Oops, sorry about that, it was not intentional.

> 
> I would appreciate if you can pick the fixups from [1] and [2] to sync rk3288/rk3399 code.

Sure, I'll have a look.

> Please also squash both MPEG-2 commits, that is closer to the original commit at [4].

Hm, okay. I thought it'd be preferable to split that in 2 or even 3
commits (one adding the core infra and one per platform), but if
everyone is okay with having things squashed in a single commit I'll do
that.

> 
> This module seems to crash after repeated rmmod / insmod, calls to video_device_release
> seems to be the culprit for crash. There is also an issue with uneven pm runtime autosuspend calls
> leaving clocks enabled when module is unloaded.
> 
> Feel free to pick/squash any of the changes at [3], they fixes the crash and uneven autosuspend for me.

Will do.

> 
> MPEG-2 decoding is working on my RK3288 and RK3399 devices.
> 
> Fixup commits:
> [1] https://github.com/Kwiboo/linux-rockchip/commit/8d8b5aca522176d17b6a0f13da57fd9b8e7d1e9a
> [2] https://github.com/Kwiboo/linux-rockchip/commit/75de5f322ffe889154832f6ebfb08e48257af526
> [3] https://github.com/Kwiboo/linux-rockchip/commit/0729b53c825a630c9040d28541d2635a42177361
> 
> Original MPEG-2 commit:
> [4] https://github.com/Kwiboo/linux-rockchip/commit/25d9502927540c6f17c65d52a350b28c664cbf5a
> 
> Thanks,

Thanks for reviewing/testing/debugging.

Boris