Re: [PATCH v3 03/13] rockchip: dts: rk3399: Create initial rk3399-u-boot.dtsi

Jagan Teki
2019-04-26T13:21:45Z

On Thu, Apr 25, 2019 at 11:04 PM Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> wrote:
>
> u-boot,dm-pre-reloc is required for SDMMC booted rk3399 boards and
> which is U-Boot specific devicetrees binding.
>
> Move it on global rk3399-u-boot.dtsi file and rest of the U-Boot
> bindings will move it future based on the requirement.
>
> This would help to sync the devicetrees from Linux whenever required
> instead of adding specific nodes.
>
> Signed-off-by: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
> Reviewed-by: Paul Kocialkowski <paul.kocialkowski-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
> ---
> arch/arm/dts/rk3399-evb.dts | 1 -
> arch/arm/dts/rk3399-firefly.dts | 1 -
> arch/arm/dts/rk3399-puma.dtsi | 1 -
> arch/arm/dts/rk3399-u-boot.dtsi | 8 ++++++++
> 4 files changed, 8 insertions(+), 3 deletions(-)
> create mode 100644 arch/arm/dts/rk3399-u-boot.dtsi
>
> diff --git a/arch/arm/dts/rk3399-evb.dts b/arch/arm/dts/rk3399-evb.dts
> index ce004d0d18..9162f3dd50 100644
> --- a/arch/arm/dts/rk3399-evb.dts
> +++ b/arch/arm/dts/rk3399-evb.dts
> @@ -155,7 +155,6 @@
> };
>
> &sdmmc {
> - u-boot,dm-pre-reloc;
> bus-width = <4>;
> status = "okay";
> };
> diff --git a/arch/arm/dts/rk3399-firefly.dts b/arch/arm/dts/rk3399-firefly.dts
> index f90e7e88db..46f2ffaf8d 100644
> --- a/arch/arm/dts/rk3399-firefly.dts
> +++ b/arch/arm/dts/rk3399-firefly.dts
> @@ -592,7 +592,6 @@
> };
>
> &sdmmc {
> - u-boot,dm-pre-reloc;
> bus-width = <4>;
> status = "okay";
> };
> diff --git a/arch/arm/dts/rk3399-puma.dtsi b/arch/arm/dts/rk3399-puma.dtsi
> index 8304f67192..9049694243 100644
> --- a/arch/arm/dts/rk3399-puma.dtsi
> +++ b/arch/arm/dts/rk3399-puma.dtsi
> @@ -492,7 +492,6 @@
> };
>
> &sdmmc {
> - u-boot,dm-pre-reloc;

We need to explicitly include rk3399-u-boot.dtsi to these files since
the SoC name is rockchip, I'm sending other series for these changes.
and I have send v3.1 patches for only this change [1] and rest
unchanged.

Sorry for not noticing before.

[1] https://patchwork.ozlabs.org/patch/1091534/