From: Mark Brown <broonie@kernel.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
Nicolas Boichat <drinkcat@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Brian Norris <briannorris@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] Revert "platform/chrome: cros_ec_spi: Transfer messages at high priority"
Date: Mon, 13 May 2019 17:01:53 +0100 [thread overview]
Message-ID: <20190513160153.GD5168@sirena.org.uk> (raw)
In-Reply-To: <CAD=FV=Xg96SGg-JDjEJRtC6jACcN9Xizcr-zV4rQwXYvuEvmRA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 579 bytes --]
On Mon, May 13, 2019 at 08:57:12AM -0700, Doug Anderson wrote:
> On Sun, May 12, 2019 at 10:05 AM Mark Brown <broonie@kernel.org> wrote:
> > It isn't clear to me that it's a bad thing to have this even with the
> > SPI thread at realime priority.
> The code that's there right now isn't enough. As per the description
> in the original patch, it didn't solve all problems but just made
> things an order of magnitude better. So if I don't do this revert I
I'm not saying the other changes aren't helping, I'm saying that it's
not clear that this revert is improving things.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-05-13 16:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 22:34 [PATCH 0/4] spi: A better solution for cros_ec_spi reliability Douglas Anderson
2019-05-10 22:34 ` [PATCH 1/4] spi: For controllers that need realtime always use the pump thread Douglas Anderson
2019-05-11 0:24 ` Guenter Roeck
[not found] ` <20190510223437.84368-2-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2019-05-12 7:33 ` Mark Brown
2019-05-13 20:24 ` Doug Anderson
2019-05-14 9:30 ` Mark Brown
2019-05-14 14:42 ` Doug Anderson
2019-05-14 15:06 ` Mark Brown
2019-05-10 22:34 ` [PATCH 2/4] spi: Allow SPI devices to specify that they are timing sensitive Douglas Anderson
[not found] ` <20190510223437.84368-3-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2019-05-11 0:31 ` Guenter Roeck
2019-05-12 7:42 ` Mark Brown
2019-05-10 22:34 ` [PATCH 3/4] platform/chrome: cros_ec_spi: Set ourselves as " Douglas Anderson
2019-05-11 0:32 ` Guenter Roeck
[not found] ` <20190510223437.84368-1-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2019-05-10 22:34 ` [PATCH 4/4] Revert "platform/chrome: cros_ec_spi: Transfer messages at high priority" Douglas Anderson
2019-05-11 0:32 ` Guenter Roeck
[not found] ` <20190510223437.84368-5-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2019-05-12 7:45 ` Mark Brown
2019-05-13 15:57 ` Doug Anderson
2019-05-13 16:01 ` Mark Brown [this message]
2019-05-13 16:03 ` Doug Anderson
2019-05-13 16:47 ` Mark Brown
2019-05-13 20:21 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190513160153.GD5168@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bleung@chromium.org \
--cc=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=drinkcat@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox