Re: [REPOST PATCH v2 2/3] USB: dwc2: Don't turn off the usbphy in suspend if wakeup is enabled

From: kbuild test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Amelie Delaunay <amelie.delaunay-qxv4g6HH51o@public.gmane.org>,
	heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org>,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	Alan Stern
	<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>,
	Artur Petrosyan
	<Arthur.Petrosyan-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>,
	Elaine Zhang <zhangqing-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	amstan-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	Felipe Balbi
	<felipe.balbi-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	Randy Li <ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>,
	Minas Harutyunyan
	<hminas-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>,
	Greg Kroah-Hartman
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Douglas Anderson
	<dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	ryandcase-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	kbuild-all-JC7UmRfGjtg@public.gmane.org,
	William Wu <william.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	jwerner-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org
Subject: Re: [REPOST PATCH v2 2/3] USB: dwc2: Don't turn off the usbphy in suspend if wakeup is enabled
Date: Mon, 20 May 2019 10:07:32 +0800	[thread overview]
Message-ID: <201905201037.p3rNy0yX%lkp@intel.com> (raw)
In-Reply-To: <20190516225941.170355-3-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1925 bytes --]

Hi Douglas,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on balbi-usb/next]
[also build test ERROR on v5.2-rc1 next-20190517]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Douglas-Anderson/Documentation-dt-bindings-Add-snps-need-phy-for-wake-for-dwc2-USB/20190520-033119
base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: x86_64-randconfig-h0-05191510 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

All errors (new ones prefixed by >>):

   ld: drivers/usb/dwc2/platform.o: in function `dwc2_can_poweroff_phy':
>> drivers/usb/dwc2/platform.c:545: undefined reference to `usb_wakeup_enabled_descendants'

vim +545 drivers/usb/dwc2/platform.c

   529	
   530	static bool __maybe_unused dwc2_can_poweroff_phy(struct dwc2_hsotg *dwc2)
   531	{
   532		struct usb_device *root_hub = dwc2_hsotg_to_hcd(dwc2)->self.root_hub;
   533	
   534		if (!dwc2->ll_hw_enabled)
   535			return false;
   536	
   537		/* If the controller isn't allowed to wakeup then we can power off. */
   538		if (!device_may_wakeup(dwc2->dev))
   539			return true;
   540	
   541		/*
   542		 * We don't want to power off the PHY if something under the
   543		 * root hub has wakeup enabled.
   544		 */
 > 545		if (usb_wakeup_enabled_descendants(root_hub))
   546			return false;
   547	
   548		/* No reason to keep the PHY powered, so allow poweroff */
   549		return true;
   550	}
   551	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30199 bytes --]

[-- Attachment #3: Type: text/plain, Size: 200 bytes --]

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip