From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH] media: rockchip/vpu: remove an unnecessary NULL check Date: Fri, 7 Jun 2019 16:26:19 +0200 Message-ID: <20190607162619.06a3186d@collabora.com> References: <20190607135609.GA16718@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190607135609.GA16718@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Dan Carpenter Cc: Heiko Stuebner , kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Hans Verkuil , Mauro Carvalho Chehab , Ezequiel Garcia , linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rockchip.vger.kernel.org On Fri, 7 Jun 2019 16:56:09 +0300 Dan Carpenter wrote: > Thus the address of "&ctx->dev->variant->codec_ops[codec_mode]" > can't possibly be NULL. > > Signed-off-by: Dan Carpenter Reviewed-by: Boris Brezillon > --- > drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c b/drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c > index 1b80a45df8fe..42f4eb0abc8a 100644 > --- a/drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c > +++ b/drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c > @@ -619,7 +619,7 @@ static int rockchip_vpu_start_streaming(struct vb2_queue *q, > > vpu_debug(4, "Codec mode = %d\n", codec_mode); > ctx->codec_ops = &ctx->dev->variant->codec_ops[codec_mode]; > - if (ctx->codec_ops && ctx->codec_ops->init) > + if (ctx->codec_ops->init) > ret = ctx->codec_ops->init(ctx); > } >