From: Mark Brown <broonie@kernel.org>
To: Tzung-Bi Shih <tzungbi@google.com>
Cc: ALSA development <alsa-devel@alsa-project.org>,
dianders@chromium.org, Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
dri-devel@lists.freedesktop.org,
Hans Verkuil <hverkuil@xs4all.nl>,
Andrzej Hajda <a.hajda@samsung.com>,
Russell King <rmk+kernel@armlinux.org.uk>,
tzungbi@chromium.org,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Daniel Vetter <daniel@ffwll.ch>,
dgreid@chromium.org, linux-arm-kernel@lists.infradead.org,
Cheng-Yi Chiang <cychiang@chromium.org>
Subject: Re: [PATCH 1/4] ASoC: hdmi-codec: Add an op to set callback function for plug event
Date: Fri, 5 Jul 2019 13:12:40 +0100 [thread overview]
Message-ID: <20190705121240.GA20625@sirena.org.uk> (raw)
In-Reply-To: <CA+Px+wXtmf9dQQP7ywPLp7Qbbvqau=WnO3qhZ8+qmbJD1gjx+A@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 523 bytes --]
On Fri, Jul 05, 2019 at 03:08:37PM +0800, Tzung-Bi Shih wrote:
> On Fri, Jul 5, 2019 at 12:26 PM Cheng-Yi Chiang <cychiang@chromium.org> wrote:
> > +typedef void (*hdmi_codec_plugged_cb)(struct platform_device *dev,
> > + bool plugged);
> > +
> The callback prototype is "weird" by struct platform_device. Is it
> possible to having snd_soc_component instead of platform_device?
Or if it's got to be a device why not just a generic device so
we're not tied to a particular bus here?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2019-07-05 12:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 4:26 [PATCH 0/4] Add HDMI jack support on RK3288 Cheng-Yi Chiang
2019-07-05 4:26 ` [PATCH 1/4] ASoC: hdmi-codec: Add an op to set callback function for plug event Cheng-Yi Chiang
2019-07-05 7:08 ` Tzung-Bi Shih
2019-07-05 12:12 ` Mark Brown [this message]
2019-07-08 5:03 ` Cheng-yi Chiang
2019-07-09 11:58 ` Cheng-yi Chiang
[not found] ` <20190705042623.129541-2-cychiang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2019-07-09 11:47 ` Cezary Rojewski
2019-07-09 11:55 ` Cheng-yi Chiang
2019-07-05 4:26 ` [PATCH 2/4] drm: bridge: dw-hdmi: Report connector status using callback Cheng-Yi Chiang
2019-07-05 5:45 ` [alsa-devel] " Jonas Karlman
2019-07-05 7:31 ` Cheng-yi Chiang
2019-07-05 17:16 ` Mark Brown
2019-07-06 10:17 ` Cheng-yi Chiang
2019-07-05 7:09 ` Tzung-Bi Shih
2019-07-05 7:35 ` Cheng-yi Chiang
2019-07-05 4:26 ` [PATCH 3/4] ASoC: rockchip_max98090: Add dai_link for HDMI Cheng-Yi Chiang
2019-07-05 7:09 ` Tzung-Bi Shih
2019-07-06 9:58 ` Cheng-yi Chiang
2019-07-05 4:26 ` [PATCH 4/4] ASoC: rockchip_max98090: Add HDMI jack support Cheng-Yi Chiang
2019-07-05 8:30 ` [PATCH 0/4] Add HDMI jack support on RK3288 Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190705121240.GA20625@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=alsa-devel@alsa-project.org \
--cc=cychiang@chromium.org \
--cc=daniel@ffwll.ch \
--cc=dgreid@chromium.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hverkuil@xs4all.nl \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=tiwai@suse.com \
--cc=tzungbi@chromium.org \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox