From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamie Iles Subject: Re: [PATCH -next 07/12] crypto: picoxcell - use devm_platform_ioremap_resource() to simplify code Date: Sat, 3 Aug 2019 15:13:00 +0100 Message-ID: <20190803141300.GA26817@willow> References: <20190802132809.8116-1-yuehaibing@huawei.com> <20190802132809.8116-8-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190802132809.8116-8-yuehaibing@huawei.com> Sender: linux-kernel-owner@vger.kernel.org To: YueHaibing Cc: herbert@gondor.apana.org.au, lars.persson@axis.com, jesper.nilsson@axis.com, davem@davemloft.net, thomas.lendacky@amd.com, gary.hook@amd.com, krzk@kernel.org, kgene@kernel.org, antoine.tenart@bootlin.com, matthias.bgg@gmail.com, jamie@jamieiles.com, agross@kernel.org, heiko@sntech.de, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, clabbe.montjoie@gmail.com, mripard@kernel.org, wens@csie.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@axis.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com List-Id: linux-rockchip.vger.kernel.org On Fri, Aug 02, 2019 at 09:28:04PM +0800, YueHaibing wrote: > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Acked-by: Jamie Iles > --- > drivers/crypto/picoxcell_crypto.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/crypto/picoxcell_crypto.c b/drivers/crypto/picoxcell_crypto.c > index b985cb85..9a939b4 100644 > --- a/drivers/crypto/picoxcell_crypto.c > +++ b/drivers/crypto/picoxcell_crypto.c > @@ -1624,7 +1624,7 @@ MODULE_DEVICE_TABLE(of, spacc_of_id_table); > static int spacc_probe(struct platform_device *pdev) > { > int i, err, ret; > - struct resource *mem, *irq; > + struct resource *irq; > struct device_node *np = pdev->dev.of_node; > struct spacc_engine *engine = devm_kzalloc(&pdev->dev, sizeof(*engine), > GFP_KERNEL); > @@ -1653,8 +1653,7 @@ static int spacc_probe(struct platform_device *pdev) > > engine->name = dev_name(&pdev->dev); > > - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - engine->regs = devm_ioremap_resource(&pdev->dev, mem); > + engine->regs = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(engine->regs)) > return PTR_ERR(engine->regs); > > -- > 2.7.4 > >