From mboxrd@z Thu Jan  1 00:00:00 1970
From: "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>
Subject: Re: [PATCHv2 3/4] drm/komeda: use afbc helpers
Date: Thu, 14 Nov 2019 01:52:25 +0000
Message-ID: <20191114015220.GA16456@jamwan02-TSP300>
References: <2485717.1SzL54aMiy@e123338-lin>
 <20191104221228.3588-1-andrzej.p@collabora.com>
 <20191104221228.3588-4-andrzej.p@collabora.com>
 <20191108160954.GA17321@arm.com> <20191113020146.GB2746@jamwan02-TSP300>
 <20191113113954.GN23790@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-Reply-To: <20191113113954.GN23790@phenom.ffwll.local>
Content-Language: en-US
Content-ID: <3ADD614D554ECD48A0A061B62474F6DE@eurprd08.prod.outlook.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: nd <nd@arm.com>, Mihail Atanassov <Mihail.Atanassov@arm.com>, "kernel@collabora.com" <kernel@collabora.com>, David Airlie <airlied@linux.ie>, Liviu Dudau <Liviu.Dudau@arm.com>, Andrzej Pietrasiewicz <andrzej.p@collabora.com>, "linux-rockchip@lists.infradead.org" <linux-rockchip@lists.infradead.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, Ayan Halder <Ayan.Halder@arm.com>, Sean Paul <sean@poorly.run>
List-Id: linux-rockchip.vger.kernel.org

T24gV2VkLCBOb3YgMTMsIDIwMTkgYXQgMTI6Mzk6NTRQTSArMDEwMCwgRGFuaWVsIFZldHRlciB3
cm90ZToKPiBPbiBXZWQsIE5vdiAxMywgMjAxOSBhdCAwMjowMTo1M0FNICswMDAwLCBqYW1lcyBx
aWFuIHdhbmcgKEFybSBUZWNobm9sb2d5IENoaW5hKSB3cm90ZToKPiA+IE9uIEZyaSwgTm92IDA4
LCAyMDE5IGF0IDA0OjA5OjU0UE0gKzAwMDAsIEF5YW4gSGFsZGVyIHdyb3RlOgo+ID4gPiBPbiBN
b24sIE5vdiAwNCwgMjAxOSBhdCAxMToxMjoyN1BNICswMTAwLCBBbmRyemVqIFBpZXRyYXNpZXdp
Y3ogd3JvdGU6Cj4gPiA+ID4gVGhlcmUgYXJlIGFmYmMgaGVscGVycyBhdmFpbGFibGUuCj4gPiA+
ID4gCj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogQW5kcnplaiBQaWV0cmFzaWV3aWN6IDxhbmRyemVq
LnBAY29sbGFib3JhLmNvbT4KPiA+ID4gPiAtLS0KPiA+ID4gPiAgLi4uL2FybS9kaXNwbGF5L2tv
bWVkYS9rb21lZGFfZm9ybWF0X2NhcHMuaCAgIHwgIDEgLQo+ID4gPiA+ICAuLi4vYXJtL2Rpc3Bs
YXkva29tZWRhL2tvbWVkYV9mcmFtZWJ1ZmZlci5jICAgfCA0NCArKysrKysrLS0tLS0tLS0tLS0t
Cj4gPiA+ID4gIDIgZmlsZXMgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgMjggZGVsZXRpb25z
KC0pCj4gPiA+ID4gCj4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hcm0vZGlz
cGxheS9rb21lZGEva29tZWRhX2Zvcm1hdF9jYXBzLmggYi9kcml2ZXJzL2dwdS9kcm0vYXJtL2Rp
c3BsYXkva29tZWRhL2tvbWVkYV9mb3JtYXRfY2Fwcy5oCj4gPiA+ID4gaW5kZXggMzIyNzNjZjE4
ZjdjLi42MDdlZWE4MGU2MGMgMTAwNjQ0Cj4gPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2Fy
bS9kaXNwbGF5L2tvbWVkYS9rb21lZGFfZm9ybWF0X2NhcHMuaAo+ID4gPiA+ICsrKyBiL2RyaXZl
cnMvZ3B1L2RybS9hcm0vZGlzcGxheS9rb21lZGEva29tZWRhX2Zvcm1hdF9jYXBzLmgKPiA+ID4g
PiBAQCAtMzMsNyArMzMsNiBAQAo+ID4gPiA+ICAKPiA+ID4gPiAgI2RlZmluZSBBRkJDX1RIX0xB
WU9VVF9BTElHTk1FTlQJOAo+ID4gPiA+ICAjZGVmaW5lIEFGQkNfSEVBREVSX1NJWkUJCTE2Cj4g
PiA+ID4gLSNkZWZpbmUgQUZCQ19TVVBFUkJMS19BTElHTk1FTlQJCTEyOAo+ID4gPiA+ICAjZGVm
aW5lIEFGQkNfU1VQRVJCTEtfUElYRUxTCQkyNTYKPiA+ID4gPiAgI2RlZmluZSBBRkJDX0JPRFlf
U1RBUlRfQUxJR05NRU5UCTEwMjQKPiA+ID4gPiAgI2RlZmluZSBBRkJDX1RIX0JPRFlfU1RBUlRf
QUxJR05NRU5UCTQwOTYKPiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FybS9k
aXNwbGF5L2tvbWVkYS9rb21lZGFfZnJhbWVidWZmZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9hcm0v
ZGlzcGxheS9rb21lZGEva29tZWRhX2ZyYW1lYnVmZmVyLmMKPiA+ID4gPiBpbmRleCAxYjAxYTYy
NWY0MGUuLmU5Yzg3NTUxYTViOCAxMDA2NDQKPiA+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v
YXJtL2Rpc3BsYXkva29tZWRhL2tvbWVkYV9mcmFtZWJ1ZmZlci5jCj4gPiA+ID4gKysrIGIvZHJp
dmVycy9ncHUvZHJtL2FybS9kaXNwbGF5L2tvbWVkYS9rb21lZGFfZnJhbWVidWZmZXIuYwo+ID4g
PiA+IEBAIC00LDYgKzQsNyBAQAo+ID4gPiA+ICAgKiBBdXRob3I6IEphbWVzLlFpYW4uV2FuZyA8
amFtZXMucWlhbi53YW5nQGFybS5jb20+Cj4gPiA+ID4gICAqCj4gPiA+ID4gICAqLwo+ID4gPiA+
ICsjaW5jbHVkZSA8ZHJtL2RybV9hZmJjLmg+Cj4gPiA+ID4gICNpbmNsdWRlIDxkcm0vZHJtX2Rl
dmljZS5oPgo+ID4gPiA+ICAjaW5jbHVkZSA8ZHJtL2RybV9mYl9jbWFfaGVscGVyLmg+Cj4gPiA+
ID4gICNpbmNsdWRlIDxkcm0vZHJtX2dlbS5oPgo+ID4gPiA+IEBAIC00Myw4ICs0NCw3IEBAIGtv
bWVkYV9mYl9hZmJjX3NpemVfY2hlY2soc3RydWN0IGtvbWVkYV9mYiAqa2ZiLCBzdHJ1Y3QgZHJt
X2ZpbGUgKmZpbGUsCj4gPiA+ID4gIAlzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiA9ICZrZmIt
PmJhc2U7Cj4gPiA+ID4gIAljb25zdCBzdHJ1Y3QgZHJtX2Zvcm1hdF9pbmZvICppbmZvID0gZmIt
PmZvcm1hdDsKPiA+ID4gPiAgCXN0cnVjdCBkcm1fZ2VtX29iamVjdCAqb2JqOwo+ID4gPiA+IC0J
dTMyIGFsaWdubWVudF93ID0gMCwgYWxpZ25tZW50X2ggPSAwLCBhbGlnbm1lbnRfaGVhZGVyLCBu
X2Jsb2NrcywgYnBwOwo+ID4gPiA+IC0JdTY0IG1pbl9zaXplOwo+ID4gPiA+ICsJdTMyIGFsaWdu
bWVudF93ID0gMCwgYWxpZ25tZW50X2ggPSAwLCBhbGlnbm1lbnRfaGVhZGVyLCBicHA7Cj4gPiA+
ID4gIAo+ID4gPiA+ICAJb2JqID0gZHJtX2dlbV9vYmplY3RfbG9va3VwKGZpbGUsIG1vZGVfY21k
LT5oYW5kbGVzWzBdKTsKPiA+ID4gPiAgCWlmICghb2JqKSB7Cj4gPiA+ID4gQEAgLTUyLDE5ICs1
MiwxNSBAQCBrb21lZGFfZmJfYWZiY19zaXplX2NoZWNrKHN0cnVjdCBrb21lZGFfZmIgKmtmYiwg
c3RydWN0IGRybV9maWxlICpmaWxlLAo+ID4gPiA+ICAJCXJldHVybiAtRU5PRU5UOwo+ID4gPiA+
ICAJfQo+ID4gPiA+ICAKPiA+ID4gPiAtCXN3aXRjaCAoZmItPm1vZGlmaWVyICYgQUZCQ19GT1JN
QVRfTU9EX0JMT0NLX1NJWkVfTUFTSykgewo+ID4gPiA+IC0JY2FzZSBBRkJDX0ZPUk1BVF9NT0Rf
QkxPQ0tfU0laRV8zMng4Ogo+ID4gPiA+IC0JCWFsaWdubWVudF93ID0gMzI7Cj4gPiA+ID4gLQkJ
YWxpZ25tZW50X2ggPSA4Owo+ID4gPiA+IC0JCWJyZWFrOwo+ID4gPiA+IC0JY2FzZSBBRkJDX0ZP
Uk1BVF9NT0RfQkxPQ0tfU0laRV8xNngxNjoKPiA+ID4gPiAtCQlhbGlnbm1lbnRfdyA9IDE2Owo+
ID4gPiA+IC0JCWFsaWdubWVudF9oID0gMTY7Cj4gPiA+ID4gLQkJYnJlYWs7Cj4gPiA+ID4gLQlk
ZWZhdWx0Ogo+ID4gPiA+IC0JCVdBUk4oMSwgIkludmFsaWQgQUZCQ19GT1JNQVRfTU9EX0JMT0NL
X1NJWkU6ICVsbGQuXG4iLAo+ID4gPiA+IC0JCSAgICAgZmItPm1vZGlmaWVyICYgQUZCQ19GT1JN
QVRfTU9EX0JMT0NLX1NJWkVfTUFTSyk7Cj4gPiA+ID4gLQkJYnJlYWs7Cj4gPiA+ID4gKwlpZiAo
IWRybV9hZmJjX2dldF9zdXBlcmJsa193aChmYi0+bW9kaWZpZXIsICZhbGlnbm1lbnRfdywgJmFs
aWdubWVudF9oKSkKPiA+ID4gPiArCQlyZXR1cm4gLUVJTlZBTDsKPiA+ID4gPiArCj4gPiA+ID4g
KwlpZiAoKGFsaWdubWVudF93ICE9IDE2IHx8IGFsaWdubWVudF9oICE9IDE2KSAmJgo+ID4gPiA+
ICsJICAgIChhbGlnbm1lbnRfdyAhPSAzMiB8fCBhbGlnbm1lbnRfaCAhPSA4KSkgewo+ID4gPiA+
ICsJCURSTV9ERUJVR19LTVMoIlVuc3VwcG9ydGVkIGFmYmMgdGlsZSB3L2ggWyVkLyVkXVxuIiwK
PiA+ID4gPiArCQkJICAgICAgYWxpZ25tZW50X3csIGFsaWdubWVudF9oKTsKPiA+ID4gPiArCj4g
PiA+ID4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4gPiA+IFRvIGJlIGhvbmVzdCwgdGhlIHByZXZpb3Vz
IGNvZGUgbG9va3MgbXVjaCBtb3JlIHJlYWRhYmxlCj4gPiA+ID4gIAl9Cj4gPiA+ID4gIAo+ID4g
PiA+ICAJLyogdGlsZWQgaGVhZGVyIGFmYmMgKi8KPiA+ID4gPiBAQCAtODQsMjAgKzgwLDE0IEBA
IGtvbWVkYV9mYl9hZmJjX3NpemVfY2hlY2soc3RydWN0IGtvbWVkYV9mYiAqa2ZiLCBzdHJ1Y3Qg
ZHJtX2ZpbGUgKmZpbGUsCj4gPiA+ID4gIAkJZ290byBjaGVja19mYWlsZWQ7Cj4gPiA+ID4gIAl9
Cj4gPiA+ID4gIAo+ID4gPiA+IC0Jbl9ibG9ja3MgPSAoa2ZiLT5hbGlnbmVkX3cgKiBrZmItPmFs
aWduZWRfaCkgLyBBRkJDX1NVUEVSQkxLX1BJWEVMUzsKPiA+ID4gPiAtCWtmYi0+b2Zmc2V0X3Bh
eWxvYWQgPSBBTElHTihuX2Jsb2NrcyAqIEFGQkNfSEVBREVSX1NJWkUsCj4gPiA+ID4gLQkJCQkg
ICAgYWxpZ25tZW50X2hlYWRlcik7Cj4gPiA+ID4gLQo+ID4gPiA+ICAJYnBwID0ga29tZWRhX2dl
dF9hZmJjX2Zvcm1hdF9icHAoaW5mbywgZmItPm1vZGlmaWVyKTsKPiA+ID4gPiAtCWtmYi0+YWZi
Y19zaXplID0ga2ZiLT5vZmZzZXRfcGF5bG9hZCArIG5fYmxvY2tzICoKPiA+ID4gPiAtCQkJIEFM
SUdOKGJwcCAqIEFGQkNfU1VQRVJCTEtfUElYRUxTIC8gOCwKPiA+ID4gPiAtCQkJICAgICAgIEFG
QkNfU1VQRVJCTEtfQUxJR05NRU5UKTsKPiA+ID4gPiAtCW1pbl9zaXplID0ga2ZiLT5hZmJjX3Np
emUgKyBmYi0+b2Zmc2V0c1swXTsKPiA+ID4gPiAtCWlmIChtaW5fc2l6ZSA+IG9iai0+c2l6ZSkg
ewo+ID4gPiA+IC0JCURSTV9ERUJVR19LTVMoImFmYmMgc2l6ZSBjaGVjayBmYWlsZWQsIG9ial9z
aXplOiAweCV6eC4gbWluX3NpemUgMHglbGx4LlxuIiwKPiA+ID4gPiAtCQkJICAgICAgb2JqLT5z
aXplLCBtaW5fc2l6ZSk7Cj4gPiA+IFdlIG5lZWQga2ZiLT5vZmZzZXRfcGF5bG9hZCBhbmQga2Zi
LT5hZmJjX3NpemUgdG8gc2V0IHNvbWUgcmVnaXN0ZXJzCj4gPiA+IGluIGQ3MV9sYXllcl91cGRh
dGUoKS4gQXQgdGhpcyBtb21lbnQgSSBmZWVsIGxpa2UgcHVuY2hpbmcgbXlzZWxmIGZvcgo+ID4g
PiBtYWtpbmcgdGhlIHN1Z2dlc3Rpb24gdG8gY29uc2lkZXIgYWJzdHJhY3Rpbmcgc29tZSBvZiB0
aGUga29tZWRhJ3MgYWZiYwo+ID4gPiBjaGVja3MuIFRvIG1lIGl0IGRvZXMgbm90IGxvb2sgbGlr
ZSBrb21lZGEoaW4gdGhlIGN1cnJlbnQgc2hhcGUpIGNhbiB0YWtlCj4gPiA+IG11Y2ggYWR2YW50
YWdlIG9mIHRoZSBnZW5lcmljIF9hZmJjX2ZiX2NoZWNrKCkgZnVuY3Rpb24gKGFzIHdhcyBzdWdn
ZXN0ZWQKPiA+ID4gcHJldmlvdXNseSBieSBEYW52ZXQpLgo+ID4gPiAKPiA+ID4gSG93ZXZlciwg
SSB3aWxsIGxldCBqYW1lcy5xaWFuLndhbmdAYXJtLmNvbSwKPiA+ID4gTWloYWlsLkF0YW5hc3Nv
dkBhcm0uY29tLCBCZW4uRGF2aXNAYXJtLmNvbSBjb21tZW50IGhlcmUgdG8gc2VlIGlmCj4gPiA+
IHRoZXJlIGNvdWxkIGJlIGEgd2F5IG9mIGFic3RyYWN0aW5nIHRoZSBhZmJjIGJpdHMgZnJvbSBr
b21lZGEuCj4gPiA+Cj4gPiAKPiA+IEhpIGFsbDoKPiA+IAo+ID4gU2luY2UgdGhlIGN1cnJlbnQg
Z2VuZXJpYyBkcm1fYWZiYyBoZWxwZXJzIG9ubHkgc3VwcG9ydCBhZmJjXzEuMSwgYnV0Cj4gPiBr
b21lZGEgbmVlZHMgc3VwcG9ydCBib3RoIGFmYmMxLjEvMS4yLCBzbyBJIHRoaW5rIHdlIGNhbjoK
PiA+IC0gQWRkIGFmYmMxLjIgc3VwcG9ydCB0byBkcm0gYWZiYyBoZWxwZXJzLgo+ID4gLSBmb3Ig
dGhlIGFmYmNfcGF5bG9hZF9vZmZzZXQsIGNhbiB3ZSBhZGQgdGhpcyBtZW1iZXIgdG8KPiA+ICAg
ZHJtX2ZyYW1lYnVmZmVyID8KPiA+IC0gVGhlIGFsaWduZWRfdy9oIGFyZSBpbXBvcnRhbnQgZm9y
IGFmYmMsIHNvIGNhbiB3ZSBoYXZlIHRoZW0gaW4KPiA+ICAgZHJtX2ZyYW1lYnVmZmVyID8gIAo+
IAo+IEhvdyBleHBlbnNpdmUgaXMgaXQgdG8gcmVjb21wdXRlIHRoZXNlIGZyb20gYSBzdHJ1Y3Qg
ZHJtX2ZyYW1lYnVmZmVyPwo+IAo+IEknZCBqdXN0IGdvIHdpdGggb25lIGZ1bmN0aW9uIHdoaWNo
IGNvbXB1dGVzIGFsbCB0aGVzZSBkZXJpdmVkIHZhbHVlcywgYW5kCj4gc3R1ZmZzIHRoZW0gaW50
byBhIHN0cnVjdCBkcm1fYWZiYy4gVGhlbiBkcml2ZXJzIGNhbGwgdGhhdCBvbmNlIG9yIHNvLgo+
CgpBIHN0cnVjdCBkcm1fYWZiYywgZ29vZCBpZGVhLCBJIGxpa2UgaXQuIDotKQoKYW5kIHdlIGNh
biBjb21wdXRlIGl0IHdoZW4gZG8gdGhlIGFmYmMgc2l6ZSBjaGVjayBsaWtlIAoKICBkcm1fYWZi
Y19jaGVja19mYl9zaXplKC4uLiwgJmtvbWVkYV9mYi0+ZHJtX2FmYmMpOwoKVGhhbmtzLgpKYW1l
cwoKPiBGb3IgcmV3b3JraW5nIGRybV9mcmFtZWJ1ZmZlciBpdHNlbGYgSSB0aGluayBpdCdzIHBy
b2JhYmx5IGEgYml0IHRvbwo+IGVhcmxpZXIuIEFuZCBpZiB3ZSBkbyBpdCwgd2Ugc2hvdWxkIG1h
eWJlIGdvIGEgYml0IG1vcmUgYm9sZCwgYWltaW5nIHRvCj4gcHJvcGVydHktZnkgYWxsIHRoZSBm
cmFtZWJ1ZmZlciBzZXR0aW5ncywgbWF5YmUgZXZlbiBtYWtpbmcgaXQgZXh0ZW5zaWJsZSwKPiBh
bmQgaGF2ZSBkcml2ZXJzIGhhbmRsZSBhIGNvcnJlc3BvbmRpbmcgZHJtX2ZyYW1lYnVmZmVyX3N0
YXRlLgo+IAo+IEEgdGhpcmQgb3B0aW9uIHdvdWxkIGJlIHRvIGNyZWF0ZSBhIGRybV9hZmJjX2Zy
YW1lYnVmZmVyIHdoaWNoIGVtYmVkcwo+IGRybV9mcmFtZWJ1ZmZlciBhbmQgd2hpY2ggZHJpdmVy
cyB3b3VsZCBuZWVkIHRvIHVzZS4gQnV0IGFsc28gZmVlbHMgYSBiaXQKPiBsaWtlIHRvbyBtdWNo
IGNodXJuLiBSZWNvbXB1dGluZyBzaG91bGQgYmUgcXVpY2sgZW5vdWdoIGFuZCBtdWNoIGVhc2ll
ci4KPiAtRGFuaWVsCj4gCj4gPiAKPiA+IFRoYW5rcwo+ID4gSmFtZXMKPiA+IAo+ID4gPiBUaGFu
a3MgYW55d2F5cyBmb3IgdGFraW5nIGEgc3RhYiBhdCB0aGlzLgo+ID4gPiAtQXlhbgo+ID4gPiA+
ICsKPiA+ID4gPiArCWlmICghZHJtX2FmYmNfY2hlY2tfZmJfc2l6ZShtb2RlX2NtZC0+cGl0Y2hl
c1swXSwgYnBwLAo+ID4gPiA+ICsJCQkJICAgIG1vZGVfY21kLT53aWR0aCwgbW9kZV9jbWQtPmhl
aWdodCwKPiA+ID4gPiArCQkJCSAgICBhbGlnbm1lbnRfdywgYWxpZ25tZW50X2gsCj4gPiA+ID4g
KwkJCQkgICAgb2JqLT5zaXplLCBtb2RlX2NtZC0+b2Zmc2V0c1swXSwKPiA+ID4gPiArCQkJCSAg
ICBBRkJDX1NVUEVSQkxLX0FMSUdOTUVOVCkpCj4gPiA+ID4gIAkJZ290byBjaGVja19mYWlsZWQ7
Cj4gPiA+ID4gLQl9Cj4gPiA+ID4gIAo+ID4gPiA+ICAJZmItPm9ialswXSA9IG9iajsKPiA+ID4g
PiAgCXJldHVybiAwOwo+ID4gPiA+IC0tIAo+ID4gPiA+IDIuMTcuMQo+IAo+IC0tIAo+IERhbmll
bCBWZXR0ZXIKPiBTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KPiBodHRwOi8v
YmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v
cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2
ZWw=