From: Andrew Murray <andrew.murray@arm.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: "Vicente Bergas" <vicencb@gmail.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Frederick Lawler" <fred@fredlawl.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Stefan Mätje" <stefan.maetje@esd.eu>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [REGRESSION] PCI v5.5-rc1 breaks google kevin
Date: Thu, 12 Dec 2019 00:52:55 +0000 [thread overview]
Message-ID: <20191212005254.GE24359@e119886-lin.cambridge.arm.com> (raw)
In-Reply-To: <166f0016-7061-be5c-660d-0499f74e8697@arm.com>
On Thu, Dec 12, 2019 at 12:12:56AM +0000, Robin Murphy wrote:
> Hi Vicente,
>
> On 2019-12-11 11:38 pm, Vicente Bergas wrote:
> > Hi,
> > since v5.5-rc1 the google kevin chromebook does not boot.
> > Git bisect reports 5e0c21c75e8c PCI/ASPM: Remove pcie_aspm_enabled()
> > unnecessary locking
> > as the first bad commit.
> >
> > In order to revert it from v5.5-rc1 i had to also revert some dependencies:
> > 5e0c21c75e8c08375a69710527e4a921b897cb7e
> > aff5d0552da4055da3faa27ee4252e48bb1f5821
> > 35efea32b26f9aacc99bf07e0d2cdfba2028b099
> > 687aaf386aeb551130f31705ce40d1341047a936
> > 72ea91afbfb08619696ccde610ee4d0d29cf4a1d
> > 87e90283c94c76ee11d379ab5a0973382bbd0baf
> > After reverting all of this, still no luck.
> > So, either the results of git bisect are not to be trusted, or
> > there are more bad commits.
> >
> > By "does not boot" i mean that the display fails to start and
> > the display is the only output device, so debugging is quite difficult.
>
> Assuming it's a manifestation of the same PCI breakage that Enric and
> Lorenzo figured out, there's a proposed fix here:
> https://lkml.org/lkml/2019/12/11/199
It's likely that any PCI driver that uses PCI IO with that controller will
suffer the same fate.
Vicente - can you try the patch that has been proposed and verify it fixes
the issue for you?
Thanks,
Andrew Murray
>
> Robin.
>
> > v5.5-rc1 as is (reverting no commits at all) works fine when disabling PCI:
> > # CONFIG_PCI is not set
> >
> > Regards,
> > Vicente.
> >
> >
> > _______________________________________________
> > Linux-rockchip mailing list
> > Linux-rockchip@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2019-12-12 0:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 23:38 [REGRESSION] PCI v5.5-rc1 breaks google kevin Vicente Bergas
2019-12-12 0:12 ` Robin Murphy
2019-12-12 0:52 ` Andrew Murray [this message]
2019-12-12 14:16 ` Enric Balletbo Serra
2019-12-12 18:40 ` Vicente Bergas
2019-12-12 20:39 ` Andrew Murray
2019-12-12 20:48 ` Vicente Bergas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212005254.GE24359@e119886-lin.cambridge.arm.com \
--to=andrew.murray@arm.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=fred@fredlawl.com \
--cc=heiko@sntech.de \
--cc=hkallweit1@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=p.zabel@pengutronix.de \
--cc=rafael.j.wysocki@intel.com \
--cc=robin.murphy@arm.com \
--cc=shawn.lin@rock-chips.com \
--cc=stefan.maetje@esd.eu \
--cc=vicencb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).