From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v3 4/7] media: hantro: h264: Use the generic H264 reflist builder Date: Mon, 16 Dec 2019 09:54:19 +0100 Message-ID: <20191216095419.4dfb8501@collabora.com> References: <20191213125414.90725-1-boris.brezillon@collabora.com> <20191213125414.90725-5-boris.brezillon@collabora.com> <24EFC68C-CF34-4D6E-8927-1CFA0CE81F45@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <24EFC68C-CF34-4D6E-8927-1CFA0CE81F45-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Hugh Cole-Baker Cc: Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org, Heiko Stuebner , Jonas Karlman , Tomasz Figa , Paul Kocialkowski , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , Sakari Ailus , Laurent Pinchart , Nicolas Dufresne , Hans Verkuil , Mauro Carvalho Chehab , Ezequiel Garcia , linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rockchip.vger.kernel.org On Sat, 14 Dec 2019 15:46:35 +0000 Hugh Cole-Baker wrote: > Hi Boris, > > > On 13 Dec 2019, at 12:54, Boris Brezillon wrote: > > > > Now that the core provides generic reflist builders, we can use them > > instead of implementing our own. > > > > Signed-off-by: Boris Brezillon > > --- > > Changes in v3: > > * New patch > > --- > > drivers/staging/media/hantro/hantro_h264.c | 237 +-------------------- > > 1 file changed, 8 insertions(+), 229 deletions(-) > > > > diff --git a/drivers/staging/media/hantro/hantro_h264.c b/drivers/staging/media/hantro/hantro_h264.c > > index 568640eab3a6..d998272d20e6 100644 > > --- a/drivers/staging/media/hantro/hantro_h264.c > > +++ b/drivers/staging/media/hantro/hantro_h264.c > > @@ -11,7 +11,7 @@ > > */ > > > > #include > > -#include > > +#include > > With this patch, CONFIG_VIDEO_HANTRO needs to depend on CONFIG_V4L2_H264, > without that it can encounter linking errors due to missing symbols for > v4l2_h264_init_reflist_builder, etc. Oops, you're right (I didn't notice it since I had it selected by CONFIG_VIDEO_ROCKCHIP_VDEC). I'll fix that in v4. Thanks, Boris