From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 2/2] dt-bindings: phy: Use a real life PX30 DSI PHY example Date: Thu, 19 Dec 2019 17:45:22 -0600 Message-ID: <20191219234415.GA22014@bogus> References: <20191213180019.25080-1-miquel.raynal@bootlin.com> <20191213180019.25080-2-miquel.raynal@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20191213180019.25080-2-miquel.raynal-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Miquel Raynal Cc: Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Heiko Stuebner , Kishon Vijay Abraham I , Paul Kocialkowski , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Thomas Petazzoni , Maxime Chevallier , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-rockchip.vger.kernel.org On Fri, Dec 13, 2019 at 07:00:19PM +0100, Miquel Raynal wrote: > Update the example phandles to reference actual nodes and give a > working starting point. > > Signed-off-by: Miquel Raynal > --- > .../devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml b/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml > index 72aca81e8959..2e35bfdf47a1 100644 > --- a/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml > +++ b/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml > @@ -60,9 +60,9 @@ examples: > dsi_dphy: phy@ff2e0000 { > compatible = "rockchip,px30-dsi-dphy"; > reg = <0x0 0xff2e0000 0x0 0x10000>; > - clocks = <&pmucru 13>, <&cru 12>; > + clocks = <&pmucru SCLK_MIPIDSIPHY_REF>, <&cru PCLK_MIPIDSIPHY>; > clock-names = "ref", "pclk"; > - resets = <&cru 12>; > + resets = <&cru SRST_MIPIDSIPHY_P>; Without the appropriate include files, this will break building the example. > reset-names = "apb"; > #phy-cells = <0>; > }; > -- > 2.20.1 >