From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Subject: Re: [PATCH 02/11] distro_bootcmd: Add SF support Date: Thu, 23 Jan 2020 12:59:12 -0500 Message-ID: <20200123175912.GZ26536@bill-the-cat> References: <20191221075440.6944-1-jagan@amarulasolutions.com> <20191221075440.6944-3-jagan@amarulasolutions.com> <20200120172240.GX8732@bill-the-cat> <8dddd74f-7b17-a614-48ab-aea0bc9148db@csgraf.de> <20200123170301.GX26536@bill-the-cat> <20200123171500.GY26536@bill-the-cat> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="iIOavGAISvUeFFLW" Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" To: Jagan Teki Cc: "open list:ARM/Rockchip SoC..." , Heinrich Schuchardt , U-Boot-Denx , Alexander Graf , linux-amarula List-Id: linux-rockchip.vger.kernel.org --iIOavGAISvUeFFLW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 23, 2020 at 10:59:17PM +0530, Jagan Teki wrote: > On Thu, Jan 23, 2020 at 10:45 PM Tom Rini wrote: > > > > On Thu, Jan 23, 2020 at 10:41:15PM +0530, Jagan Teki wrote: > > > On Thu, Jan 23, 2020 at 10:33 PM Tom Rini wrote: > > > > > > > > On Thu, Jan 23, 2020 at 10:25:50PM +0530, Jagan Teki wrote: > > > > > On Mon, Jan 20, 2020 at 11:10 PM Alexander Graf = wrote: > > > > > > > > > > > > > > > > > > On 20.01.20 18:22, Tom Rini wrote: > > > > > > > +A few people that may have insight to my question > > > > > > > > > > > > > > On Sat, Dec 21, 2019 at 01:24:31PM +0530, Jagan Teki wrote: > > > > > > > > > > > > > >> Add distro boot command support for SPI flash. > > > > > > >> > > > > > > >> This distro boot will read the boot script at specific > > > > > > >> location at the flash and start sourcing the same. > > > > > > >> > > > > > > >> The common macro like BOOTENV_SHARED_FLASH would help > > > > > > >> to extend the support for nand flash in future. > > > > > > >> > > > > > > >> Cc: Tom Rini > > > > > > >> Signed-off-by: Jagan Teki > > > > > > > What distro is this for? My concern here is that hundreds of= boards > > > > > > > (literally) grow by a few hundred bytes to add in this bit of= additional > > > > > > > default logic. That's not a big problem if distributions are= now going > > > > > > > to be using SPI flash as where they're programming in their b= ootscript. > > > > > > > But, who is doing that? Thanks! > > > > > > > > > > > > > > > > > > I am not aware of any "distro" that puts a U-Boot script at off= set 0 of > > > > > > the SPI Flash. > > > > > > > > > > > > Traditionally, SPI Flash boot setups were always very hand craf= ted - > > > > > > exactly the opposite of what distro boot is for. That said, I t= hink > > > > > > supporting SPI Flash boot for rk3399 is great! Albeit I would p= ersonally > > > > > > only store U-Boot and the environment on SPI, not the target OS. > > > > > > > > > > > > Jagan, is putting a U-Boot script on the SPI Flash something yo= u thought > > > > > > of or something that the rk3399 reference board already does? I= f it's > > > > > > the latter, maybe you could add it as a board custom boot funct= ion? > > > > > > > > > > Yes it would be later that points to. rk3399 has SPI flash layout= and > > > > > out of which one of offset(script_offset_f=3D0xffe000 from > > > > > include/configs/rk3399_common.h) stored the programming script. > > > > > > > > So I'm not sure why we're adding distro boot support to SPI flash. = What > > > > is the reference platform storing there exactly? Thanks! > > > > > > I'm not sure I understand the question? we have rk3399 SBC's that boot > > > from SPI and have feasibility to run distro boot using programming > > > script store in flash offset like boot.scr does for MMC. > > > > OK, and what distro(s) today are doing that? I'm not happy with this > > patch as it's growing hundreds (literally) of boards in size and I'd > > like to know what is leveraging this functionality today, or is going to > > be as soon as it's upstream and widely available. Thanks! >=20 > Not sure about the possibility more boards using this at this point, > but I was initially created custom to rockchip and feel that it would > be useful to rest if it's generic. May be will split into rockchip > area if it's eating too much footprint. Yes, the "distro boot" functionality refers to what we need to allow boards to easily Just Work with standard off the shelf *nix distributions. Thanks! --=20 Tom --iIOavGAISvUeFFLW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE6HLbQJwaaH776GM2h/n2NdMddlIFAl4p3u0ACgkQh/n2NdMd dlJGLg//fgjMxpwkOJx4ZJE2wfdLFIjIaWfayY89nChRiywlK9RM3QYH4LnDbOMI xcJKYupT8f7KayukWlModfgOV0umA/uWLf3PFgg5Un7attGH4EmvKhvg+wqYrYTU bkPRJ0DSPB+R2vDuy1c3JPYYHeyIYh/r2zLL2aJH6RPtJkdadvB3ZXxFINaSQxsB 9aI9zJg4/oD/VPwBdd8BcROfc/YZj8AqtlQYYHIwCUGgTghyIRnaecl1lZD3ca3R RoEGt+1cw7WTyYpOAgneZFB489tlbelSc91xvDLo9gXL64CLMLDRmF3cnuQCvgcm w/0+J1zrQ5jhIdaYhCMxEVaFC+7XnZB96nLbBv9H250CtpdmZ3lZhiPE1r+1jF0j Xnggd57XQdkgfQyXlh662qYkZ8dX+HmkuFUEObHWZbRj0rQqkwQ2C0Ycctuhl9x0 FN0/VGpyr0PbtG9/AsPWpRUtra2qA8crSfPlwMUsPD/6vWtVyIc3KNalq4b0j6dl +s+hPn5fhvXVad+mpX01F6DRvFO1Ta+tSsR/T3uqoDHdCBZQwCTHE5XW71bxNBs0 CTfBGt01VpYORb6XFsYwSCgx37LNbBtVkkAC7a0cyV8s48tztWOwRujI1j5oGHJl 2uOqfzxFiOJuYfMhTtx2A7bfFC7Bs3kZCoVSbvl5e0ga5RnldgE= =y6iy -----END PGP SIGNATURE----- --iIOavGAISvUeFFLW--