From: Mauro Carvalho Chehab <mchehab+huawei-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Boris Brezillon
<boris.brezillon-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
Cc: Ezequiel Garcia
<ezequiel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>,
linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Laurent Pinchart
<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Tomasz Figa <tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Nicolas Dufresne
<nicolas-dDhyB4GVkw9AFePFGvp55w@public.gmane.org>,
kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org,
Paul Kocialkowski
<paul.kocialkowski-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>,
Jonas Karlman <jonas-uIzNG4q0ceqzQB+pC5nmwQ@public.gmane.org>,
Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
Sakari Ailus <sakari.ailus-X3B1VOXEql0@public.gmane.org>,
Hans Verkuil <hverkuil-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
Subject: Re: [PATCH v6 5/6] media: rkvdec: Add the rkvdec driver
Date: Mon, 2 Mar 2020 15:39:09 +0100 [thread overview]
Message-ID: <20200302153909.4e90227d@coco.lan> (raw)
In-Reply-To: <20200302153529.4e2429e7-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
Em Mon, 2 Mar 2020 15:35:29 +0100
Boris Brezillon <boris.brezillon-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> escreveu:
> On Mon, 2 Mar 2020 14:57:46 +0100
> Mauro Carvalho Chehab <mchehab+huawei-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
>
> > > + for (j = 0; j < 3; j++) {
> >
> > Again a magic number. I guess this came from that big "M_N" table with 4
> > elements, right? Please use a define instead of hardcoding a number
> > here.
>
> Nope, it's unrelated to the cabac_table size, it's related to how the
> HW accesses the P/B reflists (there are 1 P reflist, and 2 B reflists,
> hence the 3 here).
Ah, ok!
> I guess we can have a '#define NUM_REFLISTS 3'.
Works for me. Please use NUM_REFLISTS on a consistent way, making it
to reflect everywhere you might define or loop over those 3 reflists.
Thanks,
Mauro
next prev parent reply other threads:[~2020-03-02 14:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 16:30 [PATCH v6 0/6] media: rockchip: Add the rkvdec driver Ezequiel Garcia
[not found] ` <20200220163016.21708-1-ezequiel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2020-02-20 16:30 ` [PATCH v6 1/6] media: uapi: h264: Add DPB entry field reference flags Ezequiel Garcia
2020-02-20 16:30 ` [PATCH v6 2/6] media: v4l2-core: Add helpers to build the H264 P/B0/B1 reflists Ezequiel Garcia
2020-03-02 13:24 ` Mauro Carvalho Chehab
[not found] ` <20200302142433.0ad1b383-qA1ZUp+OV9c@public.gmane.org>
2020-03-02 14:44 ` Boris Brezillon
[not found] ` <20200302154426.5fb09f91-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2020-03-02 15:21 ` Mauro Carvalho Chehab
2020-03-05 19:42 ` Nicolas Dufresne
2020-03-05 20:15 ` Boris Brezillon
[not found] ` <20200305211535.2e9a6673-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2020-03-05 21:37 ` Mauro Carvalho Chehab
2020-02-20 16:30 ` [PATCH v6 4/6] media: dt-bindings: rockchip: Document RK3399 Video Decoder bindings Ezequiel Garcia
2020-02-20 16:30 ` [PATCH v6 3/6] media: hantro: h264: Use the generic H264 reflist builder Ezequiel Garcia
2020-02-20 16:30 ` [PATCH v6 5/6] media: rkvdec: Add the rkvdec driver Ezequiel Garcia
[not found] ` <20200220163016.21708-6-ezequiel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2020-03-02 13:57 ` Mauro Carvalho Chehab
[not found] ` <20200302145746.3e94c1d1-qA1ZUp+OV9c@public.gmane.org>
2020-03-02 14:30 ` Boris Brezillon
[not found] ` <20200302153039.0c4ff54f-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2020-03-02 14:53 ` Mauro Carvalho Chehab
2020-03-02 14:35 ` Boris Brezillon
[not found] ` <20200302153529.4e2429e7-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2020-03-02 14:39 ` Mauro Carvalho Chehab [this message]
2020-02-20 16:30 ` [PATCH v6 6/6] arm64: dts: rockchip: rk3399: Define the rockchip Video Decoder node Ezequiel Garcia
2020-02-26 12:24 ` Johan Jonker
[not found] ` <817821e3-bc51-8037-b9b9-e429c5eeb280-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-02-26 13:21 ` Heiko Stuebner
2020-02-26 17:22 ` Ezequiel Garcia
[not found] ` <8b63465c795bb0c8243eb377106138c83e0dfffe.camel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2020-03-01 0:14 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200302153909.4e90227d@coco.lan \
--to=mchehab+huawei-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=boris.brezillon-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ezequiel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=hverkuil-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org \
--cc=jonas-uIzNG4q0ceqzQB+pC5nmwQ@public.gmane.org \
--cc=kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
--cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=nicolas-dDhyB4GVkw9AFePFGvp55w@public.gmane.org \
--cc=paul.kocialkowski-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sakari.ailus-X3B1VOXEql0@public.gmane.org \
--cc=tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).