From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 1/3] dt-bindings: arm: fix Rockchip Kylin board bindings Date: Tue, 10 Mar 2020 14:27:08 -0500 Message-ID: <20200310192708.GA13604@bogus> References: <20200302092759.3291-1-jbx6244@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20200302092759.3291-1-jbx6244-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Johan Jonker Cc: heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rockchip.vger.kernel.org On Mon, 2 Mar 2020 10:27:57 +0100, Johan Jonker wrote: > A test with the command below gives this error: > > arch/arm/boot/dts/rk3036-kylin.dt.yaml: /: compatible: > ['rockchip,rk3036-kylin', 'rockchip,rk3036'] > is not valid under any of the given schemas > > Normally the dt-binding is the authoritative part, so boards should follow > the binding, but in the kylin-case the compatible from the .dts is used for > years in the field now, so fix the binding, as otherwise > we would break old users. > > Fix this error by changing 'rockchip,kylin-rk3036' to > 'rockchip,rk3036-kylin' in rockchip.yaml. > > make ARCH=arm dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/rockchip.yaml > > Signed-off-by: Johan Jonker > --- > Documentation/devicetree/bindings/arm/rockchip.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Rob Herring