From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 2/2] dt-bindings: usb: dwc2: add compatible property for rk3368 usb Date: Tue, 10 Mar 2020 14:30:13 -0500 Message-ID: <20200310193013.GA18080@bogus> References: <20200302115812.7207-1-jbx6244@gmail.com> <20200302115812.7207-2-jbx6244@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20200302115812.7207-2-jbx6244-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Johan Jonker Cc: heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rockchip.vger.kernel.org On Mon, Mar 02, 2020 at 12:58:12PM +0100, Johan Jonker wrote: > A test with the command below gives these errors: > > arch/arm64/boot/dts/rockchip/rk3368-evb-act8846.dt.yaml: usb@ff580000: compatible: > ['rockchip,rk3368-usb', 'rockchip,rk3066-usb', 'snps,dwc2'] > is not valid under any of the given schemas > arch/arm64/boot/dts/rockchip/rk3368-geekbox.dt.yaml: usb@ff580000: compatible: > ['rockchip,rk3368-usb', 'rockchip,rk3066-usb', 'snps,dwc2'] > is not valid under any of the given schemas > arch/arm64/boot/dts/rockchip/rk3368-lion-haikou.dt.yaml: usb@ff580000: compatible: > ['rockchip,rk3368-usb', 'rockchip,rk3066-usb', 'snps,dwc2'] > is not valid under any of the given schemas > arch/arm64/boot/dts/rockchip/rk3368-orion-r68-meta.dt.yaml: usb@ff580000: compatible: > ['rockchip,rk3368-usb', 'rockchip,rk3066-usb', 'snps,dwc2'] > is not valid under any of the given schemas > arch/arm64/boot/dts/rockchip/rk3368-px5-evb.dt.yaml: usb@ff580000: compatible: > ['rockchip,rk3368-usb', 'rockchip,rk3066-usb', 'snps,dwc2'] > is not valid under any of the given schemas > arch/arm64/boot/dts/rockchip/rk3368-r88.dt.yaml: usb@ff580000: compatible: > ['rockchip,rk3368-usb', 'rockchip,rk3066-usb', 'snps,dwc2'] > is not valid under any of the given schemas > > The compatible property for rk3368 dwc2 usb was somehow never added to > the documention. Fix this error by adding > 'rockchip,rk3368-usb', 'rockchip,rk3066-usb', 'snps,dwc2' > to dwc2.yaml. > > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/usb/dwc2.yaml > > Signed-off-by: Johan Jonker > --- > Documentation/devicetree/bindings/usb/dwc2.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml > index e9f4cea21..14aeb67e8 100644 > --- a/Documentation/devicetree/bindings/usb/dwc2.yaml > +++ b/Documentation/devicetree/bindings/usb/dwc2.yaml > @@ -45,6 +45,10 @@ properties: > - const: rockchip,rk3328-usb > - const: rockchip,rk3066-usb > - const: snps,dwc2 > + - items: > + - const: rockchip,rk3368-usb And you can do the same thing with this. > + - const: rockchip,rk3066-usb > + - const: snps,dwc2 > - const: lantiq,arx100-usb > - const: lantiq,xrx200-usb > - items: > -- > 2.11.0 >