From: Paul Barker <pbarker@konsulko.com>
To: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
Cc: devicetree@vger.kernel.org, linux-pwm@vger.kernel.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Marcel Ziswiler" <marcel.ziswiler@toradex.com>,
"Igor Opaniuk" <igor.opaniuk@toradex.com>,
"Philippe Schenker" <philippe.schenker@toradex.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Claudiu Beznea" <claudiu.beznea@microchip.com>,
"Fabio Estevam" <festevam@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Kevin Hilman" <khilman@baylibre.com>,
"Ludovic Desroches" <ludovic.desroches@microchip.com>,
"Maxime Ripard" <mripard@kernel.org>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Nicolas Ferre" <nicolas.ferre@microchip.>
Subject: Re: [RFC PATCH 1/7] pwm: rename the PWM_POLARITY_INVERSED enum
Date: Tue, 17 Mar 2020 13:34:50 +0000 [thread overview]
Message-ID: <20200317133450.58c25bcb@ub1910> (raw)
In-Reply-To: <20200317123231.2843297-2-oleksandr.suvorov@toradex.com>
On Tue, 17 Mar 2020 14:32:25 +0200
Oleksandr Suvorov <oleksandr.suvorov@toradex.com> wrote:
> The polarity enum definition PWM_POLARITY_INVERSED is misspelled.
> Rename it to PWM_POLARITY_INVERTED.
>
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
Looks good. PWM_POLARITY_INVERSED confused me when I was working in this area
recently. After applying to master there's no more instances of
PWM_POLARITY_INVERSED in the source tree.
Reviewed-by: Paul Barker <pbarker@konsulko.com>
--
Paul Barker
Konsulko Group
next prev parent reply other threads:[~2020-03-17 13:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 12:32 [RFC PATCH 0/7] Rework PWM_POLARITY_* flags Oleksandr Suvorov
[not found] ` <20200317123231.2843297-1-oleksandr.suvorov-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
2020-03-17 12:32 ` [RFC PATCH 1/7] pwm: rename the PWM_POLARITY_INVERSED enum Oleksandr Suvorov
2020-03-17 13:34 ` Paul Barker [this message]
2020-03-17 21:32 ` Uwe Kleine-König
[not found] ` <20200317123231.2843297-2-oleksandr.suvorov-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
2020-03-17 16:26 ` Claudiu.Beznea-UWL1GkI3JZL3oGB3hsPCZA
[not found] ` <f281a6a0-a150-514d-ef02-4e51192031d7-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org>
2020-03-17 16:39 ` Oleksandr Suvorov
2020-03-17 17:40 ` Thierry Reding
2020-03-17 21:00 ` Uwe Kleine-König
2020-03-18 22:59 ` Thierry Reding
2020-03-19 6:50 ` Uwe Kleine-König
2020-03-19 16:37 ` Thierry Reding
2020-03-19 17:30 ` Uwe Kleine-König
2020-03-19 11:40 ` Oleksandr Suvorov
[not found] ` <CAGgjyvGd4y8M0L1sFMvQ1=gPcKfUPoR13dVS7F5WZx=333KG6g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-03-19 12:10 ` Uwe Kleine-König
2020-03-19 12:57 ` Oleksandr Suvorov
2020-03-19 16:44 ` Thierry Reding
2020-03-18 11:47 ` Oleksandr Suvorov
2020-03-17 12:32 ` [RFC PATCH 6/7] arm64: dts: pwm: replace polarity constant with macro Oleksandr Suvorov
2020-03-20 10:03 ` Krzysztof Kozlowski
2020-03-17 12:32 ` [RFC PATCH 7/7] arm: " Oleksandr Suvorov
2020-03-20 10:02 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317133450.58c25bcb@ub1910 \
--to=pbarker@konsulko.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=festevam@gmail.com \
--cc=heiko@sntech.de \
--cc=igor.opaniuk@toradex.com \
--cc=khilman@baylibre.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-imx@nxp.com \
--cc=linux-pwm@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=marcel.ziswiler@toradex.com \
--cc=mripard@kernel.org \
--cc=nicolas.ferre@microchip. \
--cc=oleksandr.suvorov@toradex.com \
--cc=philippe.schenker@toradex.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).