From: Ezequiel Garcia <ezequiel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
To: linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Tomasz Figa <tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Nicolas Dufresne
<nicolas-dDhyB4GVkw9AFePFGvp55w@public.gmane.org>,
kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org,
Jonas Karlman <jonas-uIzNG4q0ceqzQB+pC5nmwQ@public.gmane.org>,
Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
Hans Verkuil <hverkuil-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>,
Alexandre Courbot
<acourbot-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Jeffrey Kardatzke
<jkardatzke-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ezequiel Garcia
<ezequiel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
Subject: [PATCH v3 0/7] hantro: set of small cleanups and fixes
Date: Wed, 25 Mar 2020 18:34:31 -0300 [thread overview]
Message-ID: <20200325213439.16509-1-ezequiel@collabora.com> (raw)
Hi all,
Cleanups and fixes, third iteration.
The main idea here is to address two issues, and while
at it, clean the driver a bit.
The first issue can be found in Patch 1, when the Request
API is used, the CAPTURE buffer should be returned _before_
the OUTPUT buffer, to avoid waking up userspace prematurely.
I noticed this issue while working on the rkvdec driver,
but this time I've decided to tackle it at the core,
in v4l2_m2m_buf_done_and_job_finish().
The second issue is a simple compliance issue, which is solved
by refactoring the driver, dealing with internal set format
properly.
Note that patch 7 still needs reviews from device tree maintainers.
Changes v3:
* Rebased media master.
* Revert buffer sequence removal change.
Changes v2:
* Fix compile warning introduced by patch 6.
* I'm adding two additional patches this time.
Patch 7 converts the binding to json-schema,
and patch 8 puts linux-rockchip mailing list in MAINTAINERS.
Thanks,
Ezequiel
Ezequiel Garcia (7):
v4l2-mem2mem: return CAPTURE buffer first
hantro: Set buffers' zeroth plane payload in .buf_prepare
hantro: Use v4l2_m2m_buf_done_and_job_finish
hantro: Remove unneeded hantro_dec_buf_finish
hantro: Move H264 motion vector calculation to a helper
hantro: Refactor for V4L2 API spec compliancy
dt-bindings: rockchip-vpu: Convert bindings to json-schema
.../bindings/media/rockchip-vpu.txt | 43 -------
.../bindings/media/rockchip-vpu.yaml | 82 +++++++++++++
MAINTAINERS | 2 +-
drivers/media/v4l2-core/v4l2-mem2mem.c | 11 +-
drivers/staging/media/hantro/hantro.h | 7 +-
drivers/staging/media/hantro/hantro_drv.c | 28 ++---
drivers/staging/media/hantro/hantro_hw.h | 31 +++++
drivers/staging/media/hantro/hantro_v4l2.c | 111 +++++++++---------
8 files changed, 193 insertions(+), 122 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/media/rockchip-vpu.txt
create mode 100644 Documentation/devicetree/bindings/media/rockchip-vpu.yaml
--
2.26.0.rc2
next reply other threads:[~2020-03-25 21:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 21:34 Ezequiel Garcia [this message]
[not found] ` <20200325213439.16509-1-ezequiel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2020-03-25 21:34 ` [PATCH v3 1/7] v4l2-mem2mem: return CAPTURE buffer first Ezequiel Garcia
2020-03-25 21:34 ` [PATCH v3 4/7] hantro: Remove unneeded hantro_dec_buf_finish Ezequiel Garcia
2020-03-25 21:34 ` [PATCH v3 5/7] hantro: Move H264 motion vector calculation to a helper Ezequiel Garcia
2020-03-25 21:34 ` [PATCH v3 7/7] dt-bindings: rockchip-vpu: Convert bindings to json-schema Ezequiel Garcia
[not found] ` <20200325213439.16509-8-ezequiel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2020-03-26 16:55 ` Rob Herring
2020-03-26 19:08 ` Ezequiel Garcia
2020-03-26 16:59 ` Rob Herring
[not found] ` <CAL_Jsq+oBsDoDVpRUeW6z-92_wYbA1CHvJnSX-ALk3igbMmJJg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-03-26 19:09 ` Ezequiel Garcia
2020-03-26 19:13 ` [PATCH v4] " Ezequiel Garcia
2020-03-27 3:05 ` Rob Herring
2020-04-20 13:33 ` Johan Jonker
2020-04-21 2:59 ` Ezequiel Garcia
[not found] ` <12f6d7cf-6af6-4f54-3188-65e73b703a72-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-04-21 13:19 ` Johan Jonker
2020-04-21 13:36 ` Johan Jonker
2020-04-21 13:44 ` Hans Verkuil
2020-04-21 13:52 ` Ezequiel Garcia
2020-03-25 21:34 ` [PATCH v3 2/7] hantro: Set buffers' zeroth plane payload in .buf_prepare Ezequiel Garcia
2020-03-25 21:34 ` [PATCH v3 3/7] hantro: Use v4l2_m2m_buf_done_and_job_finish Ezequiel Garcia
2020-03-25 21:34 ` [PATCH v3 6/7] hantro: Refactor for V4L2 API spec compliancy Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325213439.16509-1-ezequiel@collabora.com \
--to=ezequiel-zgy8ohtn/8qb+jhodadfcq@public.gmane.org \
--cc=acourbot-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=hverkuil-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org \
--cc=jkardatzke-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=jonas-uIzNG4q0ceqzQB+pC5nmwQ@public.gmane.org \
--cc=kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=nicolas-dDhyB4GVkw9AFePFGvp55w@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox