From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH v9 0/8] Add endpoint driver for R-Car PCIe controller Date: Thu, 7 May 2020 19:44:46 +0200 Message-ID: <20200507174446.GC1216@bug> References: <1587666159-6035-1-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1587666159-6035-1-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> Sender: linux-renesas-soc-owner@vger.kernel.org To: Lad Prabhakar Cc: Yoshihiro Shimoda , Kishon Vijay Abraham I , Lorenzo Pieralisi , Bjorn Helgaas , Rob Herring , Andrew Murray , Tom Joseph , Jingoo Han , Gustavo Pimentel , Marek Vasut , Shawn Lin , Heiko Stuebner , Geert Uytterhoeven , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Lad Prabhakar List-Id: linux-rockchip.vger.kernel.org Hi! > R-Car/RZ-G2x SoC's, this also extends the epf framework to handle multiple windows > supported by the controller for mapping PCI address locally. > > Note: > The cadence/rockchip/designware endpoint drivers are build tested only. > > Changes for v9 (Re-spun this series as there were minimal changes requested): ... > * Replaced mdelay(1) with usleep_range(1000, 1001) in rcar_pcie_ep_assert_intx() Are you sure that is good idea? You are requesting 1ms sleep time with 1us tolerance, I dont believe common systems can do that. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html