From: Katsuhiro Suzuki <katsuhiro@katsuster.net>
To: Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org
Cc: Katsuhiro Suzuki <katsuhiro@katsuster.net>,
linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org,
Heiko Stuebner <heiko@sntech.de>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] dt-bindings: sound: add missing clock description of rk3328 DT schema
Date: Tue, 23 Jun 2020 21:47:34 +0900 [thread overview]
Message-ID: <20200623124734.1736470-2-katsuhiro@katsuster.net> (raw)
In-Reply-To: <20200623124734.1736470-1-katsuhiro@katsuster.net>
This patch adds description about "mclk" clock and fixes some errors
which are dt_binding_check reported.
Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
---
.../bindings/sound/rockchip,rk3328-codec.yaml | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/rockchip,rk3328-codec.yaml b/Documentation/devicetree/bindings/sound/rockchip,rk3328-codec.yaml
index 08a74e28e483..525b48c2f5de 100644
--- a/Documentation/devicetree/bindings/sound/rockchip,rk3328-codec.yaml
+++ b/Documentation/devicetree/bindings/sound/rockchip,rk3328-codec.yaml
@@ -19,10 +19,12 @@ properties:
clocks:
items:
- description: clock for audio codec
+ - description: clock for I2S master clock
clock-names:
items:
- const: pclk
+ - const: mclk
rockchip,grf:
$ref: /schemas/types.yaml#/definitions/phandle
@@ -41,21 +43,28 @@ properties:
GPIO specifier for external line driver control (typically the
dedicated GPIO_MUTE pin)
+ "#sound-dai-cells":
+ const: 0
+
required:
- compatible
- reg
- clocks
- clock-names
- rockchip,grf
+ - "#sound-dai-cells"
examples:
- |
+ #include <dt-bindings/gpio/gpio.h>
+ #include <dt-bindings/clock/rk3328-cru.h>
codec: codec@ff410000 {
compatible = "rockchip,rk3328-codec";
reg = <0xff410000 0x1000>;
- clocks = <&cru PCLK_ACODEC>;
- clock-names = "pclk";
+ clocks = <&cru PCLK_ACODECPHY>, <&cru SCLK_I2S1>;
+ clock-names = "pclk", "mclk";
rockchip,grf = <&grf>;
mute-gpios = <&grf_gpio 0 GPIO_ACTIVE_LOW>;
- spk-depop-time-ms = 100;
+ spk-depop-time-ms = <100>;
+ #sound-dai-cells = <0>;
};
--
2.27.0
next prev parent reply other threads:[~2020-06-23 12:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 12:47 [PATCH 1/2] dt-bindings: sound: convert rk3328 codec binding to yaml Katsuhiro Suzuki
2020-06-23 12:47 ` Katsuhiro Suzuki [this message]
[not found] ` <20200623124734.1736470-1-katsuhiro-WKCMddiH/C4xsqv6Oivclw@public.gmane.org>
2020-06-29 22:00 ` Rob Herring
2020-06-30 13:54 ` Katsuhiro Suzuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200623124734.1736470-2-katsuhiro@katsuster.net \
--to=katsuhiro@katsuster.net \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox