From: Jonathan Cameron <jic23@kernel.org>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: Lee Jones <lee.jones@linaro.org>,
knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 30/30] iio: adc: rockchip_saradc: Demote Demote seemingly unintentional kerneldoc header
Date: Sat, 18 Jul 2020 17:15:36 +0100 [thread overview]
Message-ID: <20200718171536.5b5ac001@archlinux> (raw)
In-Reply-To: <4422628.h3HLAr0T0d@diego>
On Fri, 17 Jul 2020 21:10:27 +0200
Heiko Stübner <heiko@sntech.de> wrote:
> Am Freitag, 17. Juli 2020, 18:55:38 CEST schrieb Lee Jones:
> > This is the only use of kerneldoc in the source file and no
> > descriptions are provided.
> >
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/iio/adc/rockchip_saradc.c:190: warning: Function parameter or member 'reset' not described in 'rockchip_saradc_reset_controller'
> >
> > Cc: Heiko Stuebner <heiko@sntech.de>
> > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > Cc: linux-rockchip@lists.infradead.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
>
> Subject-line says "Demote Demote..."
>
> Otherwise
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Fixed up and applied.
Thanks for whole set Lee.
Jonathan
>
>
> > ---
> > drivers/iio/adc/rockchip_saradc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
> > index 582ba047c4a67..cf4ec59c1dab0 100644
> > --- a/drivers/iio/adc/rockchip_saradc.c
> > +++ b/drivers/iio/adc/rockchip_saradc.c
> > @@ -183,7 +183,7 @@ static const struct of_device_id rockchip_saradc_match[] = {
> > };
> > MODULE_DEVICE_TABLE(of, rockchip_saradc_match);
> >
> > -/**
> > +/*
> > * Reset SARADC Controller.
> > */
> > static void rockchip_saradc_reset_controller(struct reset_control *reset)
> >
>
>
>
>
prev parent reply other threads:[~2020-07-18 16:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200717165538.3275050-1-lee.jones@linaro.org>
2020-07-17 16:55 ` [PATCH 30/30] iio: adc: rockchip_saradc: Demote Demote seemingly unintentional kerneldoc header Lee Jones
[not found] ` <20200717165538.3275050-31-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2020-07-17 19:10 ` Heiko Stübner
2020-07-18 16:15 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200718171536.5b5ac001@archlinux \
--to=jic23@kernel.org \
--cc=heiko@sntech.de \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox