From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22C0CC433E0 for ; Wed, 12 Aug 2020 08:34:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D847920781 for ; Wed, 12 Aug 2020 08:34:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BbDB4rPN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D847920781 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rock-chips.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:To:From: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zaZI3Jpx/LpWSAEoYxtt7PGtC0/sXvTwUYzPer9oRZo=; b=BbDB4rPNxGb1sij5zOb8yk4XmP 4xhFpPr09NgLJPmLPQwImWv2MLWfuAB/LCn0ffsgHkhWHdpaFdjgPQ1fgZINbc5rBbUxOK6msUc3H By8hqTdmj94lkpCEIcmYCagE6I82mqe/h5B9W+ti6c5JCFoNdV5pkPY9sXpdZaHncQgteFqZ247QM jcJ7p4xynA9VqlW+rJkNy8fuKSpCcu2hIaXLklVbY2l5P/1EvWFJD7BoGDcO6arrYL0sc/YcdEnJK WOQ211xS/NdvZvQvDOCCCIiNDN9jD3XIW/7DdSYSFgc/jss7y9IuYkTPtQdgy4PtwHoiaILbXBBVY y5QQkNkw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5mDW-0003af-9E; Wed, 12 Aug 2020 08:34:38 +0000 Received: from lucky1.263xmail.com ([211.157.147.134]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5mDK-0003Xm-DM; Wed, 12 Aug 2020 08:34:33 +0000 Received: from localhost (unknown [192.168.167.209]) by lucky1.263xmail.com (Postfix) with ESMTP id 1D2F4C0C54; Wed, 12 Aug 2020 16:34:15 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED: 0 X-ANTISPAM-LEVEL: 2 X-ABS-CHECKED: 0 Received: from localhost.localdomain (unknown [103.29.142.67]) by smtp.263.net (postfix) whith ESMTP id P31771T140662796187392S1597221250509047_; Wed, 12 Aug 2020 16:34:15 +0800 (CST) X-IP-DOMAINF: 1 X-UNIQUE-TAG: <69b1af1b415bf5000b6580fc378eeefa> X-RL-SENDER: algea.cao@rock-chips.com X-SENDER: algea.cao@rock-chips.com X-LOGIN-NAME: algea.cao@rock-chips.com X-FST-TO: a.hajda@samsung.com X-SENDER-IP: 103.29.142.67 X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 X-System-Flag: 0 From: Algea Cao To: a.hajda@samsung.com, kuankuan.y@gmail.com, hjc@rock-chips.com, tzimmermann@suse.de, dri-devel@lists.freedesktop.org, sam@ravnborg.org, airlied@linux.ie, heiko@sntech.de, jernej.skrabec@siol.net, algea.cao@rock-chips.com, Laurent.pinchart@ideasonboard.com, laurent.pinchart+renesas@ideasonboard.com, jonas@kwiboo.se, mripard@kernel.org, darekm@google.com, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, cychiang@chromium.org, linux-kernel@vger.kernel.org, narmstrong@baylibre.com, jbrunet@baylibre.com, maarten.lankhorst@linux.intel.com, daniel@ffwll.ch Subject: [PATCH 1/6] drm: Add connector atomic_begin/atomic_flush Date: Wed, 12 Aug 2020 16:34:07 +0800 Message-Id: <20200812083407.856-1-algea.cao@rock-chips.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200812083120.743-1-algea.cao@rock-chips.com> References: <20200812083120.743-1-algea.cao@rock-chips.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200812_043432_890251_1DE2C19C X-CRM114-Status: GOOD ( 13.61 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org In some situations, connector should get some work done when plane is updating. Such as when change output color format, hdmi should send AVMUTE to make screen black before crtc updating color format, or screen may flash. After color updating, hdmi should clear AVMUTE bring screen back to normal. The process is as follows: AVMUTE -> Update CRTC -> Update HDMI -> Clear AVMUTE So we introduce connector atomic_begin/atomic_flush. Signed-off-by: Algea Cao --- drivers/gpu/drm/drm_atomic_helper.c | 46 ++++++++++++++++++++++++ include/drm/drm_modeset_helper_vtables.h | 19 ++++++++++ 2 files changed, 65 insertions(+) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index f68c69a45752..f4abd700d2c4 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -2471,6 +2471,8 @@ void drm_atomic_helper_commit_planes(struct drm_device *dev, struct drm_atomic_state *old_state, uint32_t flags) { + struct drm_connector *connector; + struct drm_connector_state *old_connector_state, *new_connector_state; struct drm_crtc *crtc; struct drm_crtc_state *old_crtc_state, *new_crtc_state; struct drm_plane *plane; @@ -2479,6 +2481,28 @@ void drm_atomic_helper_commit_planes(struct drm_device *dev, bool active_only = flags & DRM_PLANE_COMMIT_ACTIVE_ONLY; bool no_disable = flags & DRM_PLANE_COMMIT_NO_DISABLE_AFTER_MODESET; + for_each_oldnew_connector_in_state(old_state, connector, + old_connector_state, + new_connector_state, i) { + const struct drm_connector_helper_funcs *funcs; + + if (!connector->state->crtc) + continue; + + if (!connector->state->crtc->state->active) + continue; + + funcs = connector->helper_private; + + if (!funcs || !funcs->atomic_begin) + continue; + + DRM_DEBUG_ATOMIC("flush beginning [CONNECTOR:%d:%s]\n", + connector->base.id, connector->name); + + funcs->atomic_begin(connector, old_connector_state); + } + for_each_oldnew_crtc_in_state(old_state, crtc, old_crtc_state, new_crtc_state, i) { const struct drm_crtc_helper_funcs *funcs; @@ -2550,6 +2574,28 @@ void drm_atomic_helper_commit_planes(struct drm_device *dev, funcs->atomic_flush(crtc, old_crtc_state); } + + for_each_oldnew_connector_in_state(old_state, connector, + old_connector_state, + new_connector_state, i) { + const struct drm_connector_helper_funcs *funcs; + + if (!connector->state->crtc) + continue; + + if (!connector->state->crtc->state->active) + continue; + + funcs = connector->helper_private; + + if (!funcs || !funcs->atomic_flush) + continue; + + DRM_DEBUG_ATOMIC("flushing [CONNECTOR:%d:%s]\n", + connector->base.id, connector->name); + + funcs->atomic_flush(connector, old_connector_state); + } } EXPORT_SYMBOL(drm_atomic_helper_commit_planes); diff --git a/include/drm/drm_modeset_helper_vtables.h b/include/drm/drm_modeset_helper_vtables.h index 421a30f08463..10f3f2e2fe28 100644 --- a/include/drm/drm_modeset_helper_vtables.h +++ b/include/drm/drm_modeset_helper_vtables.h @@ -1075,6 +1075,25 @@ struct drm_connector_helper_funcs { void (*atomic_commit)(struct drm_connector *connector, struct drm_connector_state *state); + /** + * @atomic_begin: + * + * flush atomic update + * + * This callback is used by the atomic modeset helpers but it is optional. + */ + void (*atomic_begin)(struct drm_connector *connector, + struct drm_connector_state *state); + + /** + * @atomic_begin: + * + * begin atomic update + * + * This callback is used by the atomic modeset helpers but it is optional. + */ + void (*atomic_flush)(struct drm_connector *connector, + struct drm_connector_state *state); /** * @prepare_writeback_job: * -- 2.25.1 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip