Re: [PATCH] drm/rockchip: Include <drm/drm_gem_cma_helper> for drm_gem_cm_vm_ops

[Sam Ravnborg <sam@ravnborg.org>]

On Mon, Sep 28, 2020 at 10:48:31AM +0200, Thomas Zimmermann wrote:
> Hi
> 
> Am 28.09.20 um 10:40 schrieb Sam Ravnborg:
> > Hi Thomas.
> > On Mon, Sep 28, 2020 at 10:16:43AM +0200, Thomas Zimmermann wrote:
> >> Include <drm/drm_gem_cma_helper.h> to get drm_gem_cma_vm_ops. Fallout
> >> from the recent conversion to GEM object functions.
> >>
> >> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> >> Reported-by: kernel test robot <lkp@intel.com>
> >> Fixes: 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
> > 
> > As this has only hit drm-misc-next and not pushed anywhere else there is
> > really no need for the Fixes: tag. At least thats my understanding.
> 
> I'm not sure what the upstream requirements are. As part of my dayjob, I
> maintain drivers for Suse distributions. If we pick the original patch,
> we also want the fixes. We have scripts that look for these Fixes tags
> to find the fixes. So it's helpful.
That makes sense, I will keep Fixes tags in the future also for
"internal" fixes then.

	Sam
> 
> > 
> > Otherwise the patch is equal to what I posted in the weekend so:
> > Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> 
> Thanks
> 
> Best regards
> Thomas
> 
> > 
> >> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> >> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> >> Cc: Christian König <christian.koenig@amd.com>
> >> Cc: Sandy Huang <hjc@rock-chips.com>
> >> Cc: "Heiko Stübner" <heiko@sntech.de>
> >> Cc: dri-devel@lists.freedesktop.org
> >> Cc: linux-arm-kernel@lists.infradead.org
> >> Cc: linux-rockchip@lists.infradead.org
> >> ---
> >>  drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> >> index 1cf4631461c9..7d5ebb10323b 100644
> >> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> >> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> >> @@ -10,6 +10,7 @@
> >>  
> >>  #include <drm/drm.h>
> >>  #include <drm/drm_gem.h>
> >> +#include <drm/drm_gem_cma_helper.h>
> >>  #include <drm/drm_prime.h>
> >>  #include <drm/drm_vma_manager.h>
> >>  
> >> -- 
> >> 2.28.0
> >>
> >> _______________________________________________
> >> dri-devel mailing list
> >> dri-devel@lists.freedesktop.org
> >> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 
> -- 
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> (HRB 36809, AG Nürnberg)
> Geschäftsführer: Felix Imendörffer
> 




_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip