From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Johan Jonker <jbx6244@gmail.com>
Cc: devicetree@vger.kernel.org, heiko@sntech.de, richard@nod.at,
Yifeng <yifeng.zhao@rock-chips.com>,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
robh+dt@kernel.org, linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, vigneshr@ti.com
Subject: Re: [PATCH v13 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others
Date: Mon, 2 Nov 2020 14:07:25 +0100 [thread overview]
Message-ID: <20201102140725.66e7dcb1@xps13> (raw)
In-Reply-To: <0b417fc2-3503-9bf6-914d-0f8b38df1914@gmail.com>
Hi Johan, Yifeng
Johan Jonker <jbx6244@gmail.com> wrote on Mon, 2 Nov 2020 13:57:56
+0100:
> Hi Yifeng,
>
> Don't poke with "ecc->bytes" ones it is set in rk_nfc_ecc_init(). It
> will not be noted by the MTD frame work or userspace. I think there's
> currently no way to let the user know that a different ECC must be used.
> Neither can the user set ECC on the fly.
>
> Example R/W flow:
>
> nand_select_target()
> chip->ecc.write_page_raw()
> chip->ecc.write_page()
>
> [..]
>
> chip->ecc.read_page_raw()
> chip->ecc.read_page()
> nand_deselect_target()
>
> A write/read with:
>
> rk_nfc_read_page_hwecc()
> rk_nfc_write_page_hwecc()
>
> or
>
> rk_nfc_read_page_raw()
> rk_nfc_write_page_raw()
>
> must end up with the same result. If we can't archive that, then we
> shouldn't offer RAW mode to the user for now. If Miquel agrees you
> should just get the driver ready now without these 2 functions and round
> things up.
What about just not supporting the BootROM area if it was marked
"reserved" by the BRom in the DT?
Raw accessors is really a nice and basic feature that I would like to
have in every new driver.
Thanks,
Miquèl
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2020-11-02 13:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 9:53 [PATCH v13 0/8] Add Rockchip NFC drivers for RK3308 and others Yifeng Zhao
2020-10-28 9:53 ` [PATCH v13 1/8] dt-bindings: mtd: Describe Rockchip RK3xxx NAND flash controller Yifeng Zhao
2020-10-28 9:53 ` [PATCH v13 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others Yifeng Zhao
2020-10-28 10:48 ` Miquel Raynal
2020-10-30 10:12 ` 赵仪峰
2020-10-30 10:26 ` Miquel Raynal
2020-10-31 11:58 ` Johan Jonker
2020-10-31 13:45 ` Johan Jonker
2020-11-02 3:46 ` 赵仪峰
2020-11-02 7:32 ` Miquel Raynal
2020-11-02 8:14 ` 赵仪峰
2020-11-02 8:20 ` Miquel Raynal
[not found] ` <e02e13a0-769d-6b73-c87e-5b7d75fd4254@rock-chips.com>
2020-11-02 12:57 ` Johan Jonker
2020-11-02 13:07 ` Miquel Raynal [this message]
2020-11-02 13:11 ` Johan Jonker
2020-11-02 16:31 ` Johan Jonker
2020-11-02 17:00 ` Miquel Raynal
2020-11-02 17:11 ` Johan Jonker
2020-11-04 7:30 ` 赵仪峰
2020-11-04 7:34 ` 赵仪峰
2020-10-28 9:53 ` [PATCH v13 3/8] MAINTAINERS: add maintainers to ROCKCHIP NFC Yifeng Zhao
2020-10-28 9:53 ` [PATCH v13 4/8] arm64: dts: rockchip: Add NFC node for RK3308 SoC Yifeng Zhao
2020-10-28 9:54 ` [PATCH v13 5/8] arm64: dts: rockchip: Add NFC node for PX30 SoC Yifeng Zhao
2020-10-28 9:54 ` [PATCH v13 6/8] arm: dts: rockchip: Add NFC node for RV1108 SoC Yifeng Zhao
2020-10-28 9:54 ` [PATCH v13 7/8] arm: dts: rockchip: Add NFC node for RK2928 and other SoCs Yifeng Zhao
2020-10-28 9:54 ` [PATCH v13 8/8] arm: dts: rockchip: Add NFC node for RK3036 SoC Yifeng Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102140725.66e7dcb1@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
--cc=yifeng.zhao@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox