From: "jay.xu@rock-chips.com" <jay.xu@rock-chips.com>
To: 许剑群 <jay.xu@rock-chips.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Heiko Stübner" <heiko@sntech.de>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH 1/2] arm64: remove select PINCTRL_ROCKCHIP from ARCH_ROCKCHIP
Date: Mon, 22 Mar 2021 08:03:27 +0800 [thread overview]
Message-ID: <202103220803269179853@rock-chips.com> (raw)
In-Reply-To: 20210305003907.1692515-2-jay.xu@rock-chips.com
Hi Heiko
I have seen [0] patch similar to this patch, but is there need to remove select GPIOLIB and PINCTRL_ROCKCHIP from ARCH_ROCKCHIP ?
[0]:https://patchwork.kernel.org/project/linux-rockchip/patch/20210316134059.2377081-1-geert+renesas@glider.be/
Best regards
--------------
jay.xu@rock-chips.com
>Prepare to make pinctrl driver of rockchip to be module able, this patch
>remove the select of PINCTRL_ROCKCHIP from ARCH_ROCKCHIP.
>
>Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
>---
> arch/arm64/Kconfig.platforms | 2 --
> drivers/pinctrl/Kconfig | 4 ++++
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
>index 6eecdef538bd..0371cc02b448 100644
>--- a/arch/arm64/Kconfig.platforms
>+++ b/arch/arm64/Kconfig.platforms
>@@ -227,9 +227,7 @@ config ARCH_RENESAS
> config ARCH_ROCKCHIP
> bool "Rockchip Platforms"
> select ARCH_HAS_RESET_CONTROLLER
>- select GPIOLIB
> select PINCTRL
>- select PINCTRL_ROCKCHIP
> select PM
> select ROCKCHIP_TIMER
> help
>diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
>index 03c62e1cb395..bf88aac7bcc6 100644
>--- a/drivers/pinctrl/Kconfig
>+++ b/drivers/pinctrl/Kconfig
>@@ -210,11 +210,15 @@ config PINCTRL_OXNAS
> config PINCTRL_ROCKCHIP
> bool
> depends on OF
>+ select GPIOLIB
> select PINMUX
> select GENERIC_PINCONF
> select GENERIC_IRQ_CHIP
> select MFD_SYSCON
> select OF_GPIO
>+ default ARCH_ROCKCHIP
>+ help
>+ This support pinctrl and gpio driver for Rockchip SoCs.
>
> config PINCTRL_SINGLE
> tristate "One-register-per-pin type device tree based pinctrl driver"
>--
>2.25.1
>
>
>
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2021-03-22 0:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 0:39 [PATCH 0/2] make rockchip pinctrl module able Jianqun Xu
2021-03-05 0:39 ` [PATCH 1/2] arm64: remove select PINCTRL_ROCKCHIP from ARCH_ROCKCHIP Jianqun Xu
2021-03-22 0:03 ` jay.xu [this message]
2021-03-05 0:39 ` [PATCH 2/2] pinctrl: rockchip: make driver be tristate module Jianqun Xu
2021-03-10 22:57 ` [PATCH 0/2] make rockchip pinctrl module able Linus Walleij
2021-03-15 15:32 ` Linus Walleij
2021-03-16 0:07 ` jay.xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202103220803269179853@rock-chips.com \
--to=jay.xu@rock-chips.com \
--cc=catalin.marinas@arm.com \
--cc=heiko@sntech.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox