From: Mark Brown <broonie@kernel.org>
To: Chris Morgan <macroalpha82@gmail.com>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com,
pierre-louis.bossart@linux.intel.com, tiwai@suse.com,
heiko@sntech.de, lee.jones@linaro.org, robh+dt@kernel.org,
perex@perex.cz, jbx6244@gmail.com, devicetree@vger.kernel.org,
linux-rockchip@lists.infradead.org, maccraft123mc@gmail.com,
Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH v10 2/4] ASoC: Add Rockchip rk817 audio CODEC support
Date: Fri, 14 May 2021 18:49:58 +0100 [thread overview]
Message-ID: <20210514174958.GC6516@sirena.org.uk> (raw)
In-Reply-To: <20210514171940.20831-3-macroalpha82@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 477 bytes --]
On Fri, May 14, 2021 at 12:19:38PM -0500, Chris Morgan wrote:
> +static int rk817_codec_parse_dt_property(struct device *dev,
> + struct rk817_codec_priv *rk817)
> +{
> + struct device_node *node = dev->parent->of_node;
> +
> + if (!node) {
> + dev_err(dev, "%s() dev->parent->of_node is NULL\n",
> + __func__);
> + return -ENODEV;
> + }
There's no need to fail the probe here, you won't be able to read any DT
properties but that shouldn't stop the driver binding.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2021-05-14 17:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 17:19 [PATCH v10 0/4] ASoC: codecs: add rk817 support Chris Morgan
2021-05-14 17:19 ` [PATCH v10 1/4] mfd: Add Rockchip rk817 audio CODEC support Chris Morgan
2021-05-14 17:19 ` [PATCH v10 2/4] ASoC: " Chris Morgan
2021-05-14 17:49 ` Mark Brown [this message]
2021-05-14 18:33 ` Chris Morgan
2021-05-14 19:58 ` Mark Brown
2021-05-14 21:04 ` Chris Morgan
2021-05-14 17:19 ` [PATCH v10 3/4] dt-bindings: " Chris Morgan
2021-05-14 17:19 ` [PATCH v10 4/4] arm64: dts: rockchip: add rk817 codec to Odroid Go Chris Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210514174958.GC6516@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-rockchip@lists.infradead.org \
--cc=maccraft123mc@gmail.com \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox